]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Implement refresh as kwargs in get_volume_stats
authorSteven Kaufer <kaufer@us.ibm.com>
Wed, 18 Feb 2015 21:45:57 +0000 (21:45 +0000)
committerSteven Kaufer <kaufer@us.ibm.com>
Wed, 18 Feb 2015 21:55:01 +0000 (21:55 +0000)
commit02f55f859f9dce178b0e6b633fe893192f4e5306
treedfbafc990b56699d59d36327dce9e430ae4a52c2
parent28adea93801b29fe129d4dad2eaa706c4d740172
Implement refresh as kwargs in get_volume_stats

When implementing the base driver "get_volume_stats" function, not all
drivers implemented 'refresh' as a kwarg. This can cause failures for any
code that simply invokes the following (assuming that refresh will default
to False -- which is does for 50+ drivers):

    driver.get_volume_stats()

This patch set updates the 7 drivers that did not implement refresh as a
kwarg so that the various driver implementations are consistent.

Closes-bug: 1423357
Change-Id: I6520155d1cbde4bf41573c170f4ea81815b5c1c2
cinder/volume/drivers/san/hp/hp_3par_common.py
cinder/volume/drivers/san/hp/hp_3par_fc.py
cinder/volume/drivers/san/hp/hp_3par_iscsi.py
cinder/volume/drivers/san/hp/hp_lefthand_cliq_proxy.py
cinder/volume/drivers/san/hp/hp_lefthand_iscsi.py
cinder/volume/drivers/san/hp/hp_lefthand_rest_proxy.py
cinder/volume/drivers/san/hp/hp_msa_common.py