]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Improve packet-filter test coverage in NEC Plugin
authorRyota MIBU <r-mibu@cq.jp.nec.com>
Tue, 9 Jul 2013 08:18:10 +0000 (17:18 +0900)
committerRyota MIBU <r-mibu@cq.jp.nec.com>
Wed, 17 Jul 2013 00:13:00 +0000 (09:13 +0900)
commit0043044f2e8ee3de8a9995bdbf51aad77f1a3fa9
treed62aebc2967a28765b219afe1187ed858c7da659
parent3ba25fa0601f411e05095bf350c0095ce3d60c8f
Improve packet-filter test coverage in NEC Plugin

blueprint nec-plugin-test-coverage

This commit adds unit tests for packet-filter in NEC Plugin.

This commit refactors packet-filter in NEC Plugin.
- Put packet-filter classes and methods into nec/packet_filter.py (a) and
  nec/db/packetfilter.py (b), NEC Plugin specific codes are in (a)
- Change stateless methods to class methods in extenstions/packetfilter.py
- Add 'convert_to' option to the attribute map of packet-filter to convert
  some string parameter to int at the api layer

Also, this commit includes the following changes in packet-filter.
- Fix attribute map of packet-filter; set in_port to allow_put=False
- Add new methods to update attribute map properly
- Make packet-filters ignore status of associated resource (network)

Change-Id: I7c0b76afb603f1f078b28610181b16ce66225d37
neutron/plugins/nec/common/exceptions.py
neutron/plugins/nec/db/models.py
neutron/plugins/nec/db/nec_plugin_base.py [deleted file]
neutron/plugins/nec/db/packetfilter.py [new file with mode: 0644]
neutron/plugins/nec/extensions/packetfilter.py
neutron/plugins/nec/nec_plugin.py
neutron/plugins/nec/packet_filter.py [new file with mode: 0644]
neutron/tests/unit/nec/test_packet_filter.py