review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/commit

Code Review / puppet-modules / puppetlabs-apt.git / commit

author	Daniele Sluijters <daenney@users.noreply.github.com>
	Mon, 2 Mar 2015 21:40:06 +0000 (22:40 +0100)
committer	Daniele Sluijters <daenney@users.noreply.github.com>
	Tue, 3 Mar 2015 16:33:14 +0000 (17:33 +0100)
commit	c57d2dd5ddafe26bd17727ab184b00fb8a166a2a
tree	bdb3242b6765933fd68090958b1c9704d7981020	tree \| snapshot
parent	396036892d81a10afb59a0cea287e620a60f7555	commit \| diff

apt: Fix all strict variable cases.

A few of these fixes are absolutely horrendous but we have no choice as
we need to stay current- and future-parser compatible for now.

Once we can go Puppet 4 only we can use the `$facts` hash lookup instead
which will return undef/nil for things that aren't set instead of them
not being defined at all.

13 files changed:

RSS Atom

manifests/params.pp		diff \| blob \| history
manifests/pin.pp		diff \| blob \| history
manifests/ppa.pp		diff \| blob \| history
manifests/source.pp		diff \| blob \| history
spec/classes/apt_spec.rb		diff \| blob \| history
spec/classes/apt_update_spec.rb		diff \| blob \| history
spec/classes/params_spec.rb		diff \| blob \| history
spec/defines/conf_spec.rb		diff \| blob \| history
spec/defines/key_spec.rb		diff \| blob \| history
spec/defines/pin_spec.rb		diff \| blob \| history
spec/defines/ppa_spec.rb		diff \| blob \| history
spec/defines/setting_spec.rb		diff \| blob \| history
templates/pin.pref.erb		diff \| blob \| history