Code Review / puppet-modules / puppetlabs-apt.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 06b5dc2) | patch
Adds check to params.pp if lab-release is not installed
authorSpencer Owen <owenspencer@gmail.com>
Thu, 10 Jul 2014 17:48:54 +0000 (11:48 -0600)
committerSpencer Owen <owenspencer@gmail.com>
Thu, 10 Jul 2014 17:48:54 +0000 (11:48 -0600)
commit64b8eb1e4a67e0d7515b2aa971564c08ef8903be
tree385173d6458ad313bc95802319de0d1a6e68840ctree | snapshot
parent06b5dc232b30e08da19374ed7c0f4f5b0a8f1262commit | diff
Adds check to params.pp if lab-release is not installed
Adds spec test

If lab-release is not installed, then the end user sees a confusing/ vague message
Error: Unsupported lsbdistid () at /modules/apt/manifests/params.pp:52
It is common for docker containers to not include this package by default

After fix, the user sees a friendlier message if lab-release is not installed
Error: Unable to determine lsbdistid, is lsb-release installed? at /modules/apt/manifests/params.pp:52
manifests/params.pp diff | blob | history
spec/classes/params_spec.rb diff | blob | history