X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Funit%2Ffacter%2Fapt_package_updates_spec.rb;h=f24481a98239d593ea2d458b46e60433205b8a91;hb=37159f228a8872abb8e385909f3e4ac905afc539;hp=dfa09270eb59d050a08812d4984846c040494efd;hpb=4ee69d08f4c0b294f99b7e114b35489fdbad805d;p=puppet-modules%2Fpuppetlabs-apt.git

diff --git a/spec/unit/facter/apt_package_updates_spec.rb b/spec/unit/facter/apt_package_updates_spec.rb
index dfa0927..f24481a 100644
--- a/spec/unit/facter/apt_package_updates_spec.rb
+++ b/spec/unit/facter/apt_package_updates_spec.rb
@@ -2,28 +2,32 @@ require 'spec_helper'
 
 describe 'apt_package_updates fact' do
   subject { Facter.fact(:apt_package_updates).value }
+
   after(:each) { Facter.clear }
 
-  describe 'on Debian based distro missing update-notifier-common' do
-    before { 
-    Facter.fact(:osfamily).stubs(:value).returns 'Debian'
-    File.stubs(:executable?).returns false
-  }
-  it { should == nil }
+  describe 'when apt has no updates' do
+    before(:each) do
+      Facter.fact(:apt_has_updates).stubs(:value).returns false
+    end
+    it { is_expected.to be nil }
   end
 
-  describe 'on Debian based distro' do
-    before { 
-    Facter.fact(:osfamily).stubs(:value).returns 'Debian'
-    File.stubs(:executable?).returns true
-    Facter::Util::Resolution.stubs(:exec).returns "puppet-common\nlinux-generic\nlinux-image-generic"
-  }
-  it {
+  describe 'when apt has updates' do
+    before(:each) do
+      Facter.fact(:osfamily).stubs(:value).returns 'Debian'
+      File.stubs(:executable?) # Stub all other calls
+      Facter::Util::Resolution.stubs(:exec) # Catch all other calls
+      File.expects(:executable?).with('/usr/bin/apt-get').returns true
+      apt_output = "Inst tzdata [2015f-0+deb8u1] (2015g-0+deb8u1 Debian:stable-updates [all])\n" \
+                   "Conf tzdata (2015g-0+deb8u1 Debian:stable-updates [all])\n" \
+                   "Inst unhide.rb [13-1.1] (22-2~bpo8+1 Debian Backports:jessie-backports [all])\n" \
+                   "Conf unhide.rb (22-2~bpo8+1 Debian Backports:jessie-backports [all])\n"
+      Facter::Util::Resolution.expects(:exec).with('/usr/bin/apt-get -s -o Debug::NoLocking=true upgrade 2>&1').returns apt_output
+    end
     if Facter.version < '2.0.0'
-      should == 'puppet-common,linux-generic,linux-image-generic'
+      it { is_expected.to eq('tzdata,unhide.rb') }
     else
-      should == ['puppet-common', 'linux-generic', 'linux-image-generic']
+      it { is_expected.to eq(['tzdata', 'unhide.rb']) }
     end
-  }
   end
 end