X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Funit%2Ffacter%2Fapt_package_updates_spec.rb;h=7960306e00f1f6f1116020690b09f880ccd9a421;hb=refs%2Fheads%2Frelease-prep;hp=49ceceeb93bd477e83584cbcc8f71002956cdadf;hpb=86f654a13baec042b6d249c3f6fb875a00351f98;p=puppet-modules%2Fpuppetlabs-apt.git

diff --git a/spec/unit/facter/apt_package_updates_spec.rb b/spec/unit/facter/apt_package_updates_spec.rb
index 49cecee..7960306 100644
--- a/spec/unit/facter/apt_package_updates_spec.rb
+++ b/spec/unit/facter/apt_package_updates_spec.rb
@@ -1,34 +1,33 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'apt_package_updates fact' do
   subject { Facter.fact(:apt_package_updates).value }
-  after(:each) { Facter.clear }
+
+  before(:each) { Facter.clear }
 
   describe 'when apt has no updates' do
-    before { 
-      Facter.fact(:apt_has_updates).stubs(:value).returns false
-    }
-    it { is_expected.to be nil }
+    before(:each) do
+      allow(Facter.fact(:apt_has_updates)).to receive(:value).and_return(false)
+    end
+
+    it { is_expected.to be_nil }
   end
 
   describe 'when apt has updates' do
-    before { 
-      Facter.fact(:osfamily).stubs(:value).returns 'Debian'
-      File.stubs(:executable?) # Stub all other calls
-      Facter::Util::Resolution.stubs(:exec) # Catch all other calls
-      File.expects(:executable?).with('/usr/bin/apt-get').returns true
-      Facter::Util::Resolution.expects(:exec).with('/usr/bin/apt-get -s -o Debug::NoLocking=true upgrade 2>&1').returns ""+
-        "Inst tzdata [2015f-0+deb8u1] (2015g-0+deb8u1 Debian:stable-updates [all])\n"+
-        "Conf tzdata (2015g-0+deb8u1 Debian:stable-updates [all])\n"+
-        "Inst unhide.rb [13-1.1] (22-2~bpo8+1 Debian Backports:jessie-backports [all])\n"+
-        "Conf unhide.rb (22-2~bpo8+1 Debian Backports:jessie-backports [all])\n"
-    }
-    it {
-      if Facter.version < '2.0.0'
-        is_expected.to eq('tzdata,unhide.rb')
-      else
-        is_expected.to eq(['tzdata','unhide.rb'])
-      end
-    }
+    before(:each) do
+      allow(Facter.fact(:osfamily)).to receive(:value).and_return('Debian')
+      allow(File).to receive(:executable?) # Stub all other calls
+      allow(Facter::Core::Execution).to receive(:execute) # Catch all other calls
+      allow(File).to receive(:executable?).with('/usr/bin/apt-get').and_return(true)
+      apt_output = "Inst tzdata [2015f-0+deb8u1] (2015g-0+deb8u1 Debian:stable-updates [all])\n" \
+                   "Conf tzdata (2015g-0+deb8u1 Debian:stable-updates [all])\n" \
+                   "Inst unhide.rb [13-1.1] (22-2~bpo8+1 Debian Backports:-backports [all])\n" \
+                   "Conf unhide.rb (22-2~bpo8+1 Debian Backports:-backports [all])\n"
+      allow(Facter::Core::Execution).to receive(:execute).with('/usr/bin/apt-get -s -o Debug::NoLocking=true upgrade 2>&1').and_return(apt_output)
+    end
+
+    it { is_expected.to eq(['tzdata', 'unhide.rb']) }
   end
 end