X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Fdefines%2Fsource_spec.rb;h=d9627172be7945275eab6ff31670cad3154d9294;hb=cd1b95b5392f216c21463a607d31f77737e2c417;hp=2ce50a2f03f0dd8a20f6f3774066445a7afc0850;hpb=480d42bb0ac385182ca17667c97bb629e7c80780;p=puppet-modules%2Fpuppetlabs-apt.git diff --git a/spec/defines/source_spec.rb b/spec/defines/source_spec.rb index 2ce50a2..d962717 100644 --- a/spec/defines/source_spec.rb +++ b/spec/defines/source_spec.rb @@ -3,45 +3,39 @@ require 'spec_helper' describe 'apt::source' do - GPG_KEY_ID = '6F6B15509CF8E59E6E469F327F438280EF8D349F' - - let :pre_condition do - 'class { "apt": }' - end - - let :title do - 'my_source' - end - + let(:id) { '6F6B15509CF8E59E6E469F327F438280EF8D349F' } + let(:title) { 'my_source' } + let(:pre_condition) { 'class { "apt": }' } let :facts do { os: { family: 'Debian', name: 'Debian', release: { - major: '8', - full: '8.0', + major: '9', + full: '9.0' }, distro: { - codename: 'jessie', - id: 'Debian', - }, - }, + codename: 'stretch', + id: 'Debian' + } + } } end context 'with defaults' do context 'without location' do it do - is_expected.to raise_error(Puppet::Error, %r{source entry without specifying a location}) + expect(subject).to raise_error(Puppet::Error, %r{source entry without specifying a location}) end end + context 'with location' do let(:params) { { location: 'hello.there' } } it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').without_content(%r{# my_source\ndeb-src hello.there wheezy main\n}) - is_expected.not_to contain_package('apt-transport-https') + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').without_content(%r{# my_source\ndeb-src hello.there wheezy main\n}) + expect(subject).not_to contain_package('apt-transport-https') } end end @@ -53,21 +47,21 @@ describe 'apt::source' do location: 'hello.there', pin: { 'release' => 'wishwash', 'explanation' => 'wishwash', - 'priority' => 1001 }, + 'priority' => 1001 } } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{hello.there jessie main\n}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{hello.there stretch main\n}) } it { is_expected.to contain_file('/etc/apt/sources.list.d/my_source.list').that_notifies('Class[Apt::Update]') } it { - is_expected.to contain_apt__pin('my_source').that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', - priority: 1001, - explanation: 'wishwash', - release: 'wishwash') + expect(subject).to contain_apt__pin('my_source').that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', + priority: 1001, + explanation: 'wishwash', + release: 'wishwash') } end @@ -78,27 +72,27 @@ describe 'apt::source' do location: 'http://debian.mirror.iweb.ca/debian/', release: 'sid', repos: 'testing', - key: GPG_KEY_ID, + key: id, pin: '10', architecture: 'x86_64', - allow_unsigned: true, + allow_unsigned: true } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# foo\ndeb \[arch=x86_64 trusted=yes\] http://debian.mirror.iweb.ca/debian/ sid testing\n}) - .without_content(%r{deb-src}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# foo\ndeb \[arch=x86_64 trusted=yes\] http://debian.mirror.iweb.ca/debian/ sid testing\n}) + .without_content(%r{deb-src}) } it { - is_expected.to contain_apt__pin('my_source').that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', - priority: '10', - origin: 'debian.mirror.iweb.ca') + expect(subject).to contain_apt__pin('my_source').that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', + priority: '10', + origin: 'debian.mirror.iweb.ca') } it { - is_expected.to contain_apt__key("Add key: #{GPG_KEY_ID} from Apt::Source my_source").that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', - id: GPG_KEY_ID) + expect(subject).to contain_apt__key("Add key: #{id} from Apt::Source my_source").that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', + id: id) } end @@ -109,48 +103,91 @@ describe 'apt::source' do location: 'http://debian.mirror.iweb.ca/debian/', release: 'sid', repos: 'testing', - key: { 'ensure' => 'refreshed', - 'id' => GPG_KEY_ID, - 'server' => 'pgp.mit.edu', - 'content' => 'GPG key content', - 'source' => 'http://apt.puppetlabs.com/pubkey.gpg' }, + key: { + 'ensure' => 'refreshed', + 'id' => id, + 'server' => 'pgp.mit.edu', + 'content' => 'GPG key content', + 'source' => 'http://apt.puppetlabs.com/pubkey.gpg', + 'weak_ssl' => true + }, pin: '10', architecture: 'x86_64', - allow_unsigned: true, + allow_unsigned: true } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# foo\ndeb \[arch=x86_64 trusted=yes\] http://debian.mirror.iweb.ca/debian/ sid testing\n}) - .without_content(%r{deb-src}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# foo\ndeb \[arch=x86_64 trusted=yes\] http://debian.mirror.iweb.ca/debian/ sid testing\n}) + .without_content(%r{deb-src}) } it { - is_expected.to contain_apt__pin('my_source').that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', - priority: '10', - origin: 'debian.mirror.iweb.ca') + expect(subject).to contain_apt__pin('my_source').that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'present', + priority: '10', + origin: 'debian.mirror.iweb.ca') } it { - is_expected.to contain_apt__key("Add key: #{GPG_KEY_ID} from Apt::Source my_source").that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'refreshed', - id: GPG_KEY_ID, - server: 'pgp.mit.edu', - content: 'GPG key content', - source: 'http://apt.puppetlabs.com/pubkey.gpg') + expect(subject).to contain_apt__key("Add key: #{id} from Apt::Source my_source").that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'refreshed', + id: id, + server: 'pgp.mit.edu', + content: 'GPG key content', + source: 'http://apt.puppetlabs.com/pubkey.gpg', + weak_ssl: true) } end end + context 'with allow_insecure true' do + let :params do + { + location: 'hello.there', + allow_insecure: true + } + end + + it { + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb \[allow-insecure=yes\] hello.there stretch main\n}) + } + end + context 'with allow_unsigned true' do let :params do { location: 'hello.there', - allow_unsigned: true, + allow_unsigned: true + } + end + + it { + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb \[trusted=yes\] hello.there stretch main\n}) + } + end + + context 'with check_valid_until false' do + let :params do + { + location: 'hello.there', + check_valid_until: false } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb \[trusted=yes\] hello.there jessie main\n}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb \[check-valid-until=false\] hello.there stretch main\n}) + } + end + + context 'with check_valid_until true' do + let :params do + { + location: 'hello.there', + check_valid_until: true + } + end + + it { + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb hello.there stretch main\n}) } end @@ -158,14 +195,14 @@ describe 'apt::source' do let :params do { location: 'hello.there', - keyring: '/usr/share/keyrings/foo-archive-keyring.gpg', + keyring: '/usr/share/keyrings/foo-archive-keyring.gpg' } end it { - is_expected.to contain_apt__setting('list-my_source') + expect(subject).to contain_apt__setting('list-my_source') .with(ensure: 'present') - .with_content(%r{# my_source\ndeb \[signed-by=/usr/share/keyrings/foo-archive-keyring.gpg\] hello.there jessie main\n}) + .with_content(%r{# my_source\ndeb \[signed-by=/usr/share/keyrings/foo-archive-keyring.gpg\] hello.there stretch main\n}) } end @@ -175,14 +212,14 @@ describe 'apt::source' do location: 'hello.there', architecture: 'amd64', allow_unsigned: true, - keyring: '/usr/share/keyrings/foo-archive-keyring.gpg', + keyring: '/usr/share/keyrings/foo-archive-keyring.gpg' } end it { - is_expected.to contain_apt__setting('list-my_source') + expect(subject).to contain_apt__setting('list-my_source') .with(ensure: 'present') - .with_content(%r{# my_source\ndeb \[arch=amd64 trusted=yes signed-by=/usr/share/keyrings/foo-archive-keyring.gpg\] hello.there jessie main\n}) + .with_content(%r{# my_source\ndeb \[arch=amd64 trusted=yes signed-by=/usr/share/keyrings/foo-archive-keyring.gpg\] hello.there stretch main\n}) } end @@ -190,12 +227,12 @@ describe 'apt::source' do let :params do { location: 'HTTPS://foo.bar', - allow_unsigned: false, + allow_unsigned: false } end it { - is_expected.to contain_package('apt-transport-https') + expect(subject).to contain_package('apt-transport-https') } end @@ -206,27 +243,27 @@ describe 'apt::source' do family: 'Debian', name: 'Debian', release: { - major: '8', - full: '8.0', + major: '9', + full: '9.0' }, distro: { - codename: 'jessie', - id: 'Debian', - }, + codename: 'stretch', + id: 'Debian' + } }, - puppetversion: Puppet.version, + puppetversion: Puppet.version } end let :params do { location: 'HTTPS://foo.bar', allow_unsigned: false, - release: 'customrelease', + release: 'customrelease' } end it { - is_expected.to contain_package('apt-transport-https') + expect(subject).to contain_package('apt-transport-https') } end @@ -238,24 +275,24 @@ describe 'apt::source' do name: 'Debian', release: { major: '10', - full: '10.0', + full: '10.0' }, distro: { codename: 'buster', - id: 'Debian', - }, - }, + id: 'Debian' + } + } } end let :params do { location: 'https://foo.bar', - allow_unsigned: false, + allow_unsigned: false } end it { - is_expected.not_to contain_package('apt-transport-https') + expect(subject).not_to contain_package('apt-transport-https') } end @@ -267,25 +304,25 @@ describe 'apt::source' do name: 'Debian', release: { major: '7', - full: '7.0', + full: '7.0' }, distro: { codename: 'wheezy', - id: 'Debian', - }, - }, + id: 'Debian' + } + } } end let :params do { location: 'hello.there', include: { 'deb' => false, 'src' => true }, - architecture: 'x86_64', + architecture: 'x86_64' } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb-src \[arch=x86_64\] hello.there wheezy main\n}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb-src \[arch=x86_64\] hello.there wheezy main\n}) } end @@ -296,12 +333,12 @@ describe 'apt::source' do let :params do { location: 'hello.there', - include: { 'deb' => false, 'src' => true }, + include: { 'deb' => false, 'src' => true } } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb-src hello.there jessie main\n}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb-src hello.there stretch main\n}) } end @@ -309,12 +346,12 @@ describe 'apt::source' do let :params do { location: 'hello.there', - include: { 'src' => true }, + include: { 'src' => true } } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb hello.there jessie main\ndeb-src hello.there jessie main\n}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{# my_source\ndeb hello.there stretch main\ndeb-src hello.there stretch main\n}) } end @@ -322,13 +359,14 @@ describe 'apt::source' do let :params do { include: { 'deb' => false }, - location: 'hello.there', + location: 'hello.there' } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').without_content(%r{deb-src hello.there wheezy main\n}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').without_content(%r{deb-src hello.there wheezy main\n}) } + it { is_expected.to contain_apt__setting('list-my_source').without_content(%r{deb hello.there wheezy main\n}) } end @@ -336,25 +374,26 @@ describe 'apt::source' do let :params do { include: { 'deb' => false, 'src' => true }, - location: 'hello.there', + location: 'hello.there' } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{deb-src hello.there jessie main\n}) + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'present').with_content(%r{deb-src hello.there stretch main\n}) } - it { is_expected.to contain_apt__setting('list-my_source').without_content(%r{deb hello.there jessie main\n}) } + + it { is_expected.to contain_apt__setting('list-my_source').without_content(%r{deb hello.there stretch main\n}) } end context 'with ensure => absent' do let :params do { - ensure: 'absent', + ensure: 'absent' } end it { - is_expected.to contain_apt__setting('list-my_source').with(ensure: 'absent') + expect(subject).to contain_apt__setting('list-my_source').with(ensure: 'absent') } end @@ -367,18 +406,18 @@ describe 'apt::source' do name: 'Debian', release: { major: '8', - full: '8.0', + full: '8.0' }, distro: { - id: 'Debian', - }, - }, + id: 'Debian' + } + } } end let(:params) { { location: 'hello.there' } } it do - is_expected.to raise_error(Puppet::Error, %r{os.distro.codename fact not available: release parameter required}) + expect(subject).to raise_error(Puppet::Error, %r{os.distro.codename fact not available: release parameter required}) end end @@ -392,19 +431,19 @@ describe 'apt::source' do let :params do { location: 'hello.there', - pin: true, + pin: true } end it do - is_expected.to raise_error(Puppet::Error, %r{expects a value}) + expect(subject).to raise_error(Puppet::Error, %r{expects a value}) end end context 'with notify_update = undef (default)' do let :params do { - location: 'hello.there', + location: 'hello.there' } end @@ -415,7 +454,7 @@ describe 'apt::source' do let :params do { location: 'hello.there', - notify_update: true, + notify_update: true } end @@ -426,7 +465,7 @@ describe 'apt::source' do let :params do { location: 'hello.there', - notify_update: false, + notify_update: false } end