X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Fdefines%2Fpin_spec.rb;h=1dd02980afe12a76f511c858fad50a295d2c9e81;hb=refs%2Fheads%2Frelease-prep;hp=52ecb97132beddc48116fca47227a889c5b61142;hpb=4ea96b8d7ec3dd0d6acabb1d7718f96b8def614c;p=puppet-modules%2Fpuppetlabs-apt.git

diff --git a/spec/defines/pin_spec.rb b/spec/defines/pin_spec.rb
index 52ecb97..1dd0298 100644
--- a/spec/defines/pin_spec.rb
+++ b/spec/defines/pin_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 describe 'apt::pin', type: :define do
   let :pre_condition do
@@ -5,143 +7,151 @@ describe 'apt::pin', type: :define do
   end
   let(:facts) do
     {
-      os: { family: 'Debian', name: 'Debian', release: { major: '7', full: '7.0' } },
-      lsbdistid: 'Debian',
-      osfamily: 'Debian',
-      lsbdistcodename: 'wheezy',
-      puppetversion: Puppet.version,
+      os: {
+        family: 'Debian',
+        name: 'Debian',
+        release: {
+          major: '9',
+          full: '9.0'
+        },
+        distro: {
+          codename: 'stretch',
+          id: 'Debian'
+        }
+      }
     }
   end
   let(:title) { 'my_pin' }
 
-  context 'defaults' do
+  context 'with defaults' do
     it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: \*\nPin: release a=my_pin\nPin-Priority: 0\n}) }
   end
 
-  context 'set version' do
+  context 'with set version' do
     let :params do
       {
         'packages' => 'vim',
-        'version'  => '1',
+        'version' => '1'
       }
     end
 
     it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: vim\nPin: version 1\nPin-Priority: 0\n}) }
   end
 
-  context 'set origin' do
+  context 'with set origin' do
     let :params do
       {
         'packages' => 'vim',
-        'origin'   => 'test',
+        'origin' => 'test'
       }
     end
 
     it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: vim\nPin: origin test\nPin-Priority: 0\n}) }
   end
 
-  context 'not defaults' do
+  context 'without defaults' do
     let :params do
       {
-        'explanation'     => 'foo',
-        'order'           => 99,
-        'release'         => '1',
-        'codename'        => 'bar',
+        'explanation' => 'foo',
+        'order' => 99,
+        'release' => '1',
+        'codename' => 'bar',
         'release_version' => '2',
-        'component'       => 'baz',
-        'originator'      => 'foobar',
-        'label'           => 'foobaz',
-        'priority'        => 10,
+        'component' => 'baz',
+        'originator' => 'foobar',
+        'label' => 'foobaz',
+        'priority' => 10
       }
     end
 
     it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: foo\nPackage: \*\nPin: release a=1, n=bar, v=2, c=baz, o=foobar, l=foobaz\nPin-Priority: 10\n}) }
+
     it {
-      is_expected.to contain_apt__setting('pref-my_pin').with('priority' => 99)
+      expect(subject).to contain_apt__setting('pref-my_pin').with('priority' => 99)
     }
   end
 
-  context 'ensure absent' do
+  context 'with ensure absent' do
     let :params do
       {
-        'ensure' => 'absent',
+        'ensure' => 'absent'
       }
     end
 
     it {
-      is_expected.to contain_apt__setting('pref-my_pin').with('ensure' => 'absent')
+      expect(subject).to contain_apt__setting('pref-my_pin').with('ensure' => 'absent')
     }
   end
 
-  context 'bad characters' do
+  context 'with bad characters' do
     let(:title) { 'such  bad && wow!' }
 
     it { is_expected.to contain_apt__setting('pref-such__bad____wow_') }
   end
 
   describe 'validation' do
-    context 'invalid order' do
+    context 'with invalid order' do
       let :params do
         {
-          'order' => 'foo',
+          'order' => 'foo'
         }
       end
 
       it do
-        is_expected.to raise_error(Puppet::Error, %r{expects an Integer value, got String})
+        expect(subject).to raise_error(Puppet::Error, %r{expects an Integer value, got String})
       end
     end
 
-    context 'packages == * and version' do
+    context 'with packages == * and version' do
       let :params do
         {
-          'version' => '1',
+          'version' => '1'
         }
       end
 
       it do
-        is_expected.to raise_error(Puppet::Error, %r{parameter version cannot be used in general form})
+        expect(subject).to raise_error(Puppet::Error, %r{parameter version cannot be used in general form})
       end
     end
 
-    context 'packages == * and release and origin' do
+    context 'with packages == * and release and origin' do
       let :params do
         {
-          'origin'  => 'test',
-          'release' => 'foo',
+          'origin' => 'test',
+          'release' => 'foo'
         }
       end
 
       it do
-        is_expected.to raise_error(Puppet::Error, %r{parameters release and origin are mutually exclusive})
+        expect(subject).to raise_error(Puppet::Error, %r{parameters release and origin are mutually exclusive})
       end
     end
 
-    context 'specific form with release and origin' do
+    context 'with specific release and origin' do
       let :params do
         {
-          'release'  => 'foo',
-          'origin'   => 'test',
-          'packages' => 'vim',
+          'release' => 'foo',
+          'origin' => 'test',
+          'packages' => 'vim'
         }
       end
 
       it do
-        is_expected.to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
+        expect(subject).to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
       end
     end
 
-    context 'specific form with version and origin' do
+    context 'with specific version and origin' do
       let :params do
         {
-          'version'  => '1',
-          'origin'   => 'test',
-          'packages' => 'vim',
+          'version' => '1',
+          'origin' => 'test',
+          'packages' => 'vim'
         }
       end
 
       it do
-        is_expected.to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
+        expect(subject).to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
       end
     end
   end