X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Fdefines%2Fmark_spec.rb;h=5375fe236f4e8c9ca3eb7cc564373f40372837ef;hb=d11099c71c077bff717787af43ca8d729df33c79;hp=6c673c41c36ae4fbd48470daba9a2f8acedfadef;hpb=06207c35da2c9ad20bc733abe43a8566b3506c28;p=puppet-modules%2Fpuppetlabs-apt.git

diff --git a/spec/defines/mark_spec.rb b/spec/defines/mark_spec.rb
index 6c673c4..5375fe2 100644
--- a/spec/defines/mark_spec.rb
+++ b/spec/defines/mark_spec.rb
@@ -4,7 +4,7 @@ require 'spec_helper'
 
 describe 'apt::mark', type: :define do
   let :title do
-    'my_source'
+    'mysource'
   end
 
   let :facts do
@@ -32,7 +32,7 @@ describe 'apt::mark', type: :define do
     end
 
     it {
-      is_expected.to contain_exec('apt-mark manual my_source')
+      is_expected.to contain_exec('apt-mark manual mysource')
     }
   end
 
@@ -51,8 +51,12 @@ describe 'apt::mark', type: :define do
   [
     'package',
     'package1',
-    'package_name',
+    'package.name',
     'package-name',
+    'package+name',
+    'p.ackagename',
+    'p+ackagename',
+    'p+',
   ].each do |value|
     describe 'with a valid resource title' do
       let :title do
@@ -71,13 +75,19 @@ describe 'apt::mark', type: :define do
     end
   end
 
+  # packagenames starting with + are not valid as the title according to puppet
+  # good thing this is also an illegal name for debian packages
   [
     '|| ls -la ||',
     'packakge with space',
     'package<>|',
     '|| touch /tmp/foo.txt ||',
+    'package_name',
+    'PackageName',
+    '.p',
+    'p',
   ].each do |value|
-    describe 'with an invalid resource title' do
+    describe "with an invalid resource title [#{value}]" do
       let :title do
         value
       end