X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Fdefines%2Fkey_spec.rb;h=005c95e4698ab6c426186e4d23b39e8fc4a92cc3;hb=3cbe24e18e071f0da9623d0752f7d9c1ee0efa5e;hp=4ba7b87eae6c777896d5de3c7a67948403060d66;hpb=7875745a8b5fe116df52f39c456e7b40c68c59a1;p=puppet-modules%2Fpuppetlabs-apt.git diff --git a/spec/defines/key_spec.rb b/spec/defines/key_spec.rb index 4ba7b87..005c95e 100644 --- a/spec/defines/key_spec.rb +++ b/spec/defines/key_spec.rb @@ -1,124 +1,413 @@ require 'spec_helper' + describe 'apt::key', :type => :define do let(:facts) { { :lsbdistid => 'Debian' } } + GPG_KEY_ID = '4BD6EC30' + let :title do - '8347A27F' + GPG_KEY_ID end - let :default_params do - { - :key => title, - :ensure => 'present', - :key_server => "keyserver.ubuntu.com", - :key_source => false, - :key_content => false - } - end + describe 'normal operation' do + describe 'default options' do + it 'contains the apt::key' do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + }) + end + it 'contains the apt_key' do + should contain_apt_key(title).with({ + :id => title, + :ensure => 'present', + :source => nil, + :server => nil, + :content => nil, + :keyserver_options => nil, + }) + end + it 'contains the apt_key present anchor' do + should contain_anchor("apt_key #{title} present") + end + end + + describe 'title and key =>' do + let :title do + 'puppetlabs' + end - [{}, - { - :ensure => 'absent' - }, - { - :ensure => 'random' - }, - { - :key_source => 'ftp://ftp.example.org/key', - }, - { - :key_content => 'deadbeef', - } - ].each do |param_set| - - let :param_hash do - param_hash = default_params.merge(param_set) - param_hash[:key].upcase! if param_hash[:key] - param_hash + let :params do { + :key => GPG_KEY_ID, + } end + + it 'contains the apt::key' do + should contain_apt__key(title).with({ + :key => GPG_KEY_ID, + :ensure => 'present', + }) + end + it 'contains the apt_key' do + should contain_apt_key(title).with({ + :id => GPG_KEY_ID, + :ensure => 'present', + :source => nil, + :server => nil, + :content => nil, + :keyserver_options => nil, + }) + end + it 'contains the apt_key present anchor' do + should contain_anchor("apt_key #{GPG_KEY_ID} present") + end end - let :params do - param_set + describe 'ensure => absent' do + let :params do { + :ensure => 'absent', + } end + + it 'contains the apt::key' do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'absent', + }) + end + it 'contains the apt_key' do + should contain_apt_key(title).with({ + :id => title, + :ensure => 'absent', + :source => nil, + :server => nil, + :content => nil, + :keyserver_options => nil, + }) + end + it 'contains the apt_key absent anchor' do + should contain_anchor("apt_key #{title} absent") + end end - let :digest do - str = String.new - str << param_hash[:key].to_s << '/' - str << param_hash[:key_content].to_s << '/' - str << param_hash[:key_source].to_s << '/' - str << param_hash[:key_server].to_s << '/' - Digest::SHA1.hexdigest(str) + describe 'key_content =>' do + let :params do { + :key_content => 'GPG key content', + } end + + it 'contains the apt::key' do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_content => params[:key_content], + }) + end + it 'contains the apt_key' do + should contain_apt_key(title).with({ + :id => title, + :ensure => 'present', + :source => nil, + :server => nil, + :content => params[:key_content], + :keyserver_options => nil, + }) + end + it 'contains the apt_key present anchor' do + should contain_anchor("apt_key #{title} present") + end end - describe "when #{param_set == {} ? "using default" : "specifying"} define parameters" do + describe 'key_source =>' do + let :params do { + :key_source => 'http://apt.puppetlabs.com/pubkey.gpg', + } end - it { - if [:present, 'present', :absent, 'absent'].include? param_hash[:ensure] - should contain_apt__params - end - } - - it { - if [:present, 'present'].include? param_hash[:ensure] - should_not contain_exec("apt::key #{param_hash[:key]} absent") - should contain_anchor("apt::key #{param_hash[:key]} present") - should contain_exec(digest).with({ - "path" => "/bin:/usr/bin", - "unless" => "/usr/bin/apt-key list | /bin/grep '#{param_hash[:key]}'" + it 'contains the apt::key' do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_source => params[:key_source], + }) + end + it 'contains the apt_key' do + should contain_apt_key(title).with({ + :id => title, + :ensure => 'present', + :source => params[:key_source], + :server => nil, + :content => nil, + :keyserver_options => nil, + }) + end + it 'contains the apt_key present anchor' do + should contain_anchor("apt_key #{title} present") + end + end + + describe 'key_server =>' do + context 'domain name' do + let :params do { + :key_server => 'pgp.mit.edu', + } end + + it 'contains the apt::key' do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_server => 'pgp.mit.edu', }) - elsif [:absent, 'absent'].include? param_hash[:ensure] - should_not contain_anchor("apt::key #{param_hash[:key]} present") - should contain_exec("apt::key #{param_hash[:key]} absent").with({ - "path" => "/bin:/usr/bin", - "onlyif" => "apt-key list | grep '#{param_hash[:key]}'", - "command" => "apt-key del '#{param_hash[:key]}'" + end + it 'contains the apt_key' do + should contain_apt_key(title).with({ + :id => title, + :ensure => 'present', + :source => nil, + :server => params[:key_server], + :content => nil, + :keyserver_options => nil, }) - else - expect { should raise_error(Puppet::Error) } + end + it 'contains the apt_key present anchor' do + should contain_anchor("apt_key #{title} present") + end + end + + context "domain with dash" do + let(:params) do{ + :key_server => 'p-gp.m-it.edu', + } end + it "should contain apt::key" do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_server => 'p-gp.m-it.edu', + }) + end + end + + context "domain begin with dash" do + let(:params) do{ + :key_server => '-pgp.mit.edu', + } end + it 'fails' do + expect { subject } .to raise_error(/does not match/) + end + end + + context "domain begin with dot" do + let(:params) do{ + :key_server => '.pgp.mit.edu', + } end + it 'fails' do + expect { subject } .to raise_error(/does not match/) end - } - - it { - if [:present, 'present'].include? param_hash[:ensure] - if param_hash[:key_content] - should contain_exec(digest).with({ - "command" => "echo '#{param_hash[:key_content]}' | /usr/bin/apt-key add -" - }) - elsif param_hash[:key_source] - should contain_exec(digest).with({ - "command" => "wget -q '#{param_hash[:key_source]}' -O- | apt-key add -" - }) - elsif param_hash[:key_server] - should contain_exec(digest).with({ - "command" => "apt-key adv --keyserver '#{param_hash[:key_server]}' --recv-keys '#{param_hash[:key]}'" - }) - end + end + + context "domain end with dot" do + let(:params) do{ + :key_server => "pgp.mit.edu.", + } end + it 'fails' do + expect { subject } .to raise_error(/does not match/) end - } + end + context "url" do + let (:params) do{ + :key_server => 'hkp://pgp.mit.edu', + } end + it "should contain apt::key" do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_server => 'hkp://pgp.mit.edu', + }) + end + end + context "url with port number" do + let (:params) do{ + :key_server => 'hkp://pgp.mit.edu:80', + } end + it "should contain apt::key" do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_server => 'hkp://pgp.mit.edu:80', + }) + end + end + + context "incorrect port number url" do + let (:params) do{ + :key_server => 'hkp://pgp.mit.edu:8008080' + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + context "incorrect protocol for url" do + let (:params) do{ + :key_server => 'abc://pgp.mit.edu:80' + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + context "missing port number url" do + let (:params) do{ + :key_server => 'hkp://pgp.mit.edu:' + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + context "url ending with a dot" do + let (:params) do{ + :key_server => 'hkp://pgp.mit.edu.' + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + context "url begin with a dash" do + let(:params) do{ + :key_server => "hkp://-pgp.mit.edu", + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + context "url with dash" do + let(:params) do{ + :key_server => 'hkp://p-gp.m-it.edu', + } end + it "should contain apt::key" do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_server => 'hkp://p-gp.m-it.edu', + }) + end + end + context "exceed characher url" do + let (:params) do{ + :key_server => 'hkp://pgpiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii.mit.edu' + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + end + + describe 'key_options =>' do + let :params do { + :key_options => 'debug', + } end + + it 'contains the apt::key' do + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + :key_options => 'debug', + }) + end + it 'contains the apt_key' do + should contain_apt_key(title).with({ + :id => title, + :ensure => 'present', + :source => nil, + :server => nil, + :content => nil, + :keyserver_options => params[:key_options], + }) + end + it 'contains the apt_key present anchor' do + should contain_anchor("apt_key #{title} present") + end end end - [{ :ensure => 'present' }, { :ensure => 'absent' }].each do |param_set| - describe "should correctly handle duplicate definitions" do + describe 'validation' do + context 'invalid key' do + let :title do + 'Out of rum. Why? Why are we out of rum?' + end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + + context 'invalid source' do + let :params do { + :key_source => 'afp://puppetlabs.com/key.gpg', + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + + context 'invalid content' do + let :params do { + :key_content => [], + } end + it 'fails' do + expect { subject }.to raise_error(/is not a string/) + end + end + + context 'invalid server' do + let :params do { + :key_server => 'two bottles of rum', + } end + it 'fails' do + expect { subject }.to raise_error(/does not match/) + end + end + + context 'invalid keyserver_options' do + let :params do { + :key_options => {}, + } end + it 'fails' do + expect { subject }.to raise_error(/is not a string/) + end + end + end + describe 'duplication' do + context 'two apt::key resources for same key, different titles' do let :pre_condition do - "apt::key { 'duplicate': key => '#{title}'; }" + "apt::key { 'duplicate': key => #{title}, }" end - let(:params) { param_set } + it 'contains two apt::key resources' do + should contain_apt__key('duplicate').with({ + :key => title, + :ensure => 'present', + }) + should contain_apt__key(title).with({ + :key => title, + :ensure => 'present', + }) + end - it { - if param_set[:ensure] == 'present' - should contain_anchor("apt::key #{title} present") - should contain_apt__key(title) - should contain_apt__key("duplicate") - elsif param_set[:ensure] == 'absent' - expect { should raise_error(Puppet::Error) } - end - } + it 'contains only a single apt_key' do + should contain_apt_key('duplicate').with({ + :id => title, + :ensure => 'present', + :source => nil, + :server => nil, + :content => nil, + :keyserver_options => nil, + }) + should_not contain_apt_key(title) + end + end + context 'two apt::key resources, different ensure' do + let :pre_condition do + "apt::key { 'duplicate': key => #{title}, ensure => 'absent', }" + end + it 'informs the user of the impossibility' do + expect { subject }.to raise_error(/already ensured as absent/) + end end end - end -