X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Fclasses%2Fapt_update_spec.rb;h=c46771a52d8b226a22101dd005e3c98a96970c96;hb=refs%2Fheads%2Ftrusted-contributors;hp=06f76de0e0ddd931f62c3914681480b07dbf4c6c;hpb=c57d2dd5ddafe26bd17727ab184b00fb8a166a2a;p=puppet-modules%2Fpuppetlabs-apt.git

diff --git a/spec/classes/apt_update_spec.rb b/spec/classes/apt_update_spec.rb
index 06f76de..c46771a 100644
--- a/spec/classes/apt_update_spec.rb
+++ b/spec/classes/apt_update_spec.rb
@@ -1,107 +1,236 @@
-#!/usr/bin/env rspec
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe 'apt::update', :type => :class do
-  context "when update['always']=true" do
-    #This should completely disable all of this logic. These tests are to guarantee that we don't somehow magically change the behavior.
-    let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy' } }
-    let (:pre_condition) { "class{'::apt': update => {'always' => true},}" }
-    it 'should trigger an apt-get update run' do
-      #set the apt_update exec's refreshonly attribute to false
-      is_expected.to contain_exec('apt_update').with({'refreshonly' => false })
-    end
-    ['always','daily','weekly','reluctantly'].each do |update_frequency|
-      context "when apt::update['frequency'] has the value of #{update_frequency}" do
-        { 'a recent run' => Time.now.to_i, 'we are due for a run' => 1406660561,'the update-success-stamp file does not exist' => -1 }.each_pair do |desc, factval|
-          context "and $::apt_update_last_success indicates #{desc}" do
-            let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :apt_update_last_success => factval, :lsbdistcodename => 'wheezy' } }
-            let (:pre_condition) { "class{'::apt': update => {'always' => true, 'frequency' => '#{update_frequency}'}, }" }
-            it 'should trigger an apt-get update run' do
-              # set the apt_update exec's refreshonly attribute to false
-              is_expected.to contain_exec('apt_update').with({'refreshonly' => false})
-            end
-          end
-          context 'when $::apt_update_last_success is nil' do
-            let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy' } }
-            let (:pre_condition) { "class{'::apt': update => {'always' => true, 'frequency' => '#{update_frequency}'}, }" }
-            it 'should trigger an apt-get update run' do
-              #set the apt_update exec\'s refreshonly attribute to false
-              is_expected.to contain_exec('apt_update').with({'refreshonly' => false})
-            end
-          end
+describe 'apt::update', type: :class do
+  context "when apt::update['frequency']='always'" do
+    {
+      'a recent run' => Time.now.to_i,
+      'we are due for a run' => 1_406_660_561,
+      'the update-success-stamp file does not exist' => -1
+    }.each_pair do |desc, factval|
+      context "when $apt_update_last_success indicates #{desc}" do
+        let(:facts) do
+          {
+            os: {
+              family: 'Debian',
+              name: 'Debian',
+              release: {
+                major: '9',
+                full: '9.0'
+              },
+              distro: {
+                codename: 'stretch',
+                id: 'Debian'
+              }
+            },
+            apt_update_last_success: factval
+          }
+        end
+        let(:pre_condition) do
+          "class{'::apt': update => {'frequency' => 'always' },}"
+        end
+
+        it 'triggers an apt-get update run' do
+          # set the apt_update exec's refreshonly attribute to false
+          expect(subject).to contain_exec('apt_update').with('refreshonly' => false)
         end
       end
     end
+    context 'when $apt_update_last_success is nil' do
+      let(:facts) do
+        {
+          os: {
+            family: 'Debian',
+            name: 'Debian',
+            release: {
+              major: '9',
+              full: '9.0'
+            },
+            distro: {
+              codename: 'stretch',
+              id: 'Debian'
+            }
+          }
+        }
+      end
+      let(:pre_condition) { "class{ '::apt': update => {'frequency' => 'always' },}" }
+
+      it 'triggers an apt-get update run' do
+        # set the apt_update exec\'s refreshonly attribute to false
+        expect(subject).to contain_exec('apt_update').with('refreshonly' => false)
+      end
+    end
+
+    context 'when Exec[apt_update] refreshonly is overridden to true and has recent run' do
+      let(:facts) do
+        {
+          os: {
+            family: 'Debian',
+            name: 'Debian',
+            release: {
+              major: '9',
+              full: '9.0'
+            },
+            distro: {
+              codename: 'stretch',
+              id: 'Debian'
+            }
+          },
+          apt_update_last_success: Time.now.to_i
+        }
+      end
+      let(:pre_condition) do
+        "
+        class{'::apt': update => {'frequency' => 'always' },}
+        Exec <| title=='apt_update' |> { refreshonly => true }
+        "
+      end
+
+      it 'skips an apt-get update run' do
+        # set the apt_update exec's refreshonly attribute to false
+        expect(subject).to contain_exec('apt_update').with('refreshonly' => true)
+      end
+    end
   end
 
-  context "when apt::update['always']=false" do
-    context "and apt::update['frequency']='always'" do
-      { 'a recent run' => Time.now.to_i, 'we are due for a run' => 1406660561,'the update-success-stamp file does not exist' => -1 }.each_pair do |desc, factval|
-        context "and $::apt_update_last_success indicates #{desc}" do
-          let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :apt_update_last_success => factval, :lsbdistcodename => 'wheezy' } }
-          let (:pre_condition) { "class{'::apt': update => {'always' => false, 'frequency' => 'always' },}" }
-          it 'should trigger an apt-get update run' do
-            #set the apt_update exec's refreshonly attribute to false
-            is_expected.to contain_exec('apt_update').with({'refreshonly' => false})
-          end
+  context "when apt::update['frequency']='reluctantly'" do
+    {
+      'a recent run' => Time.now.to_i,
+      'we are due for a run' => 1_406_660_561,
+      'the update-success-stamp file does not exist' => -1
+    }.each_pair do |desc, factval|
+      context "when $apt_update_last_success indicates #{desc}" do
+        let(:facts) do
+          {
+            os: {
+              family: 'Debian',
+              name: 'Debian',
+              release: {
+                major: '9',
+                full: '9.0'
+              },
+              distro: {
+                codename: 'stretch',
+                id: 'Debian'
+              }
+            },
+            apt_update_last_success: factval
+          }
         end
-      end
-      context 'when $::apt_update_last_success is nil' do
-        let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy' } }
-        let (:pre_condition) { "class{ '::apt': update => {'always' => false, 'frequency' => 'always' },}" }
-        it 'should trigger an apt-get update run' do
-          #set the apt_update exec\'s refreshonly attribute to false
-          is_expected.to contain_exec('apt_update').with({'refreshonly' => false})
+        let(:pre_condition) { "class{ '::apt': update => {'frequency' => 'reluctantly' },}" }
+
+        it 'does not trigger an apt-get update run' do
+          # don't change the apt_update exec's refreshonly attribute. (it should be true)
+          expect(subject).to contain_exec('apt_update').with('refreshonly' => true)
         end
       end
     end
-    context "and apt::update['frequency']='reluctantly'" do
-      {'a recent run' => Time.now.to_i, 'we are due for a run' => 1406660561,'the update-success-stamp file does not exist' => -1 }.each_pair do |desc, factval|
-        context "and $::apt_update_last_success indicates #{desc}" do
-          let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :apt_update_last_success => factval, :lsbdistcodename => 'wheezy'} }
-          let (:pre_condition) { "class{ '::apt': update => {'always' => false, 'frequency' => 'reluctantly' },}" }
-          it 'should not trigger an apt-get update run' do
-            #don't change the apt_update exec's refreshonly attribute. (it should be true)
-            is_expected.to contain_exec('apt_update').with({'refreshonly' => true})
-          end
-        end
+    context 'when $apt_update_last_success is nil' do
+      let(:facts) do
+        {
+          os: {
+            family: 'Debian',
+            name: 'Debian',
+            release: {
+              major: '9',
+              full: '9.0'
+            },
+            distro: {
+              codename: 'stretch',
+              id: 'Debian'
+            }
+          }
+        }
       end
-      context 'when $::apt_update_last_success is nil' do
-        let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy' } }
-        let (:pre_condition) { "class{ '::apt': update => {'always' => false, 'frequency' => 'reluctantly' },}" }
-        it 'should not trigger an apt-get update run' do
-          #don't change the apt_update exec's refreshonly attribute. (it should be true)
-          is_expected.to contain_exec('apt_update').with({'refreshonly' => true})
-        end
+      let(:pre_condition) { "class{ '::apt': update => {'frequency' => 'reluctantly' },}" }
+
+      it 'does not trigger an apt-get update run' do
+        # don't change the apt_update exec's refreshonly attribute. (it should be true)
+        expect(subject).to contain_exec('apt_update').with('refreshonly' => true)
       end
     end
-    ['daily','weekly'].each do |update_frequency|
-      context "and apt::update['frequency'] has the value of #{update_frequency}" do
-        { 'we are due for a run' => 1406660561,'the update-success-stamp file does not exist' => -1 }.each_pair do |desc, factval|
-          context "and $::apt_update_last_success indicates #{desc}" do
-            let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :apt_update_last_success => factval, :lsbdistcodename => 'wheezy' } }
-            let (:pre_condition) { "class{ '::apt': update => {'always' => false, 'frequency' => '#{update_frequency}',} }" }
-            it 'should trigger an apt-get update run' do
-              #set the apt_update exec\'s refreshonly attribute to false
-              is_expected.to contain_exec('apt_update').with({'refreshonly' => false})
-            end
+  end
+
+  ['daily', 'weekly'].each do |update_frequency|
+    context "when apt::update['frequency'] has the value of #{update_frequency}" do
+      pair = { 'we are due for a run' => 1_406_660_561, 'the update-success-stamp file does not exist' => -1 }
+      pair.each_pair do |desc, factval|
+        context "when $apt_update_last_success indicates #{desc}" do
+          let(:facts) do
+            {
+              os: {
+                family: 'Debian',
+                name: 'Debian',
+                release: {
+                  major: '9',
+                  full: '9.0'
+                },
+                distro: {
+                  codename: 'stretch',
+                  id: 'Debian'
+                }
+              },
+              apt_update_last_success: factval
+            }
           end
-        end
-        context 'when the $::apt_update_last_success fact has a recent value' do
-          let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy', :apt_update_last_success => Time.now.to_i } }
-            let (:pre_condition) { "class{ '::apt': update => {'always' => false, 'frequency' => '#{update_frequency}',} }" }
-          it 'should not trigger an apt-get update run' do
-            #don't change the apt_update exec\'s refreshonly attribute. (it should be true)
-            is_expected.to contain_exec('apt_update').with({'refreshonly' => true})
+          let(:pre_condition) { "class{ '::apt': update => {'frequency' => '#{update_frequency}',} }" }
+
+          it 'triggers an apt-get update run' do
+            # set the apt_update exec\'s refreshonly attribute to false
+            expect(subject).to contain_exec('apt_update').with('refreshonly' => false)
           end
         end
-        context 'when $::apt_update_last_success is nil' do
-          let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy', :apt_update_last_success => nil } }
-            let (:pre_condition) { "class{ '::apt': update => {'always' => false, 'frequency' => '#{update_frequency}',} }" }
-          it 'should trigger an apt-get update run' do
-            #set the apt_update exec\'s refreshonly attribute to false
-            is_expected.to contain_exec('apt_update').with({'refreshonly' => false})
-          end
+      end
+      context 'when the $apt_update_last_success fact has a recent value' do
+        let(:facts) do
+          {
+            os: {
+              family: 'Debian',
+              name: 'Debian',
+              release: {
+                major: '9',
+                full: '9.0'
+              },
+              distro: {
+                codename: 'stretch',
+                id: 'Debian'
+              }
+            },
+            apt_update_last_success: Time.now.to_i
+          }
+        end
+        let(:pre_condition) { "class{ '::apt': update => {'frequency' => '#{update_frequency}',} }" }
+
+        it 'does not trigger an apt-get update run' do
+          # don't change the apt_update exec\'s refreshonly attribute. (it should be true)
+          expect(subject).to contain_exec('apt_update').with('refreshonly' => true)
+        end
+      end
+
+      context 'when $apt_update_last_success is nil' do
+        let(:facts) do
+          {
+            os: {
+              family: 'Debian',
+              name: 'Debian',
+              release: {
+                major: '9',
+                full: '9.0'
+              },
+              distro: {
+                codename: 'stretch',
+                id: 'Debian'
+              }
+            },
+            apt_update_last_success: nil
+          }
+        end
+        let(:pre_condition) { "class{ '::apt': update => {'frequency' => '#{update_frequency}',} }" }
+
+        it 'triggers an apt-get update run' do
+          # set the apt_update exec\'s refreshonly attribute to false
+          expect(subject).to contain_exec('apt_update').with('refreshonly' => false)
         end
       end
     end