X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=spec%2Fclasses%2Fapt_spec.rb;h=cd3a6ec7b47f4253418e531179c9804ad5fb5394;hb=e014fc04ed8358e4f7c2e87f7434df9817a4c7bb;hp=7e97453b28a53804bf1d53780522e8f4aeec466a;hpb=55a17ac5916110ad996e85af05a18fbdf21a90d5;p=puppet-modules%2Fpuppetlabs-apt.git diff --git a/spec/classes/apt_spec.rb b/spec/classes/apt_spec.rb index 7e97453..cd3a6ec 100644 --- a/spec/classes/apt_spec.rb +++ b/spec/classes/apt_spec.rb @@ -1,18 +1,25 @@ require 'spec_helper' describe 'apt' do - let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy', :puppetversion => '3.5.0'} } - + let(:facts) do + { + :os => { :family => 'Debian', :name => 'Debian', :release => { :major => '7', :full => '7.0' }}, + :lsbdistid => 'Debian', + :osfamily => 'Debian', + :lsbdistcodename => 'wheezy', + :puppetversion => Puppet.version, + } + end context 'defaults' do - it { is_expected.to contain_file('sources.list').that_notifies('Exec[apt_update]').only_with({ + it { is_expected.to contain_file('sources.list').that_notifies('Class[Apt::Update]').only_with({ :ensure => 'file', :path => '/etc/apt/sources.list', :owner => 'root', :group => 'root', :mode => '0644', - :notify => 'Exec[apt_update]', + :notify => 'Class[Apt::Update]', })} - it { is_expected.to contain_file('sources.list.d').that_notifies('Exec[apt_update]').only_with({ + it { is_expected.to contain_file('sources.list.d').that_notifies('Class[Apt::Update]').only_with({ :ensure => 'directory', :path => '/etc/apt/sources.list.d', :owner => 'root', @@ -20,19 +27,19 @@ describe 'apt' do :mode => '0644', :purge => false, :recurse => false, - :notify => 'Exec[apt_update]', + :notify => 'Class[Apt::Update]', })} - it { is_expected.to contain_file('preferences').that_notifies('Exec[apt_update]').only_with({ + it { is_expected.to contain_file('preferences').that_notifies('Class[Apt::Update]').only_with({ :ensure => 'file', :path => '/etc/apt/preferences', :owner => 'root', :group => 'root', :mode => '0644', - :notify => 'Exec[apt_update]', + :notify => 'Class[Apt::Update]', })} - it { is_expected.to contain_file('preferences.d').that_notifies('Exec[apt_update]').only_with({ + it { is_expected.to contain_file('preferences.d').that_notifies('Class[Apt::Update]').only_with({ :ensure => 'directory', :path => '/etc/apt/preferences.d', :owner => 'root', @@ -40,7 +47,7 @@ describe 'apt' do :mode => '0644', :purge => false, :recurse => false, - :notify => 'Exec[apt_update]', + :notify => 'Class[Apt::Update]', })} it 'should lay down /etc/apt/apt.conf.d/15update-stamp' do @@ -91,6 +98,14 @@ describe 'apt' do /Acquire::https::proxy "https:\/\/localhost:8080\/";/ )} end + + context 'ensure=absent' do + let(:params) { { :proxy => { 'ensure' => 'absent'} } } + it { is_expected.to contain_apt__setting('conf-proxy').with({ + :ensure => 'absent', + :priority => '01', + })} + end end context 'lots of non-defaults' do let :params do @@ -129,10 +144,12 @@ describe 'apt' do context 'with sources defined on valid osfamily' do let :facts do - { :osfamily => 'Debian', + { :os => { :family => 'Debian', :name => 'Ubuntu', :release => { :major => '12', :full => '12.04' }}, + :osfamily => 'Debian', :lsbdistcodename => 'precise', - :lsbdistid => 'Debian', - :puppetversion => '3.5.0', + :lsbdistid => 'Ubuntu', + :lsbdistrelease => '12.04', + :puppetversion => Puppet.version, } end let(:params) { { :sources => { @@ -147,7 +164,7 @@ describe 'apt' do 'puppetlabs' => { 'location' => 'http://apt.puppetlabs.com', 'repos' => 'main', - 'key' => { 'id' => '47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30', 'server' => 'pgp.mit.edu' }, + 'key' => { 'id' => '6F6B15509CF8E59E6E469F327F438280EF8D349F', 'server' => 'pgp.mit.edu' }, } } } } @@ -169,19 +186,49 @@ describe 'apt' do it { is_expected.to contain_file('/etc/apt/sources.list.d/puppetlabs.list').with_content(/^deb http:\/\/apt.puppetlabs.com precise main$/) } end + context 'with confs defined on valid osfamily' do + let :facts do + { + :os => { :family => 'Debian', :name => 'Ubuntu', :release => { :major => '12', :full => '12.04.5' }}, + :osfamily => 'Debian', + :lsbdistcodename => 'precise', + :lsbdistid => 'Debian', + :puppetversion => Puppet.version, + } + end + let(:params) { { :confs => { + 'foo' => { + 'content' => 'foo', + }, + 'bar' => { + 'content' => 'bar', + } + } } } + + it { is_expected.to contain_apt__conf('foo').with({ + :content => 'foo', + })} + + it { is_expected.to contain_apt__conf('bar').with({ + :content => 'bar', + })} + end + context 'with keys defined on valid osfamily' do let :facts do - { :osfamily => 'Debian', + { + :os => { :family => 'Debian', :name => 'Ubuntu', :release => { :major => '12', :full => '12.04.5' }}, + :osfamily => 'Debian', :lsbdistcodename => 'precise', :lsbdistid => 'Debian', - :puppetversion => '3.5.0', + :puppetversion => Puppet.version, } end let(:params) { { :keys => { '55BE302B' => { 'server' => 'subkeys.pgp.net', }, - '4BD6EC30' => { + 'EF8D349F' => { 'server' => 'pgp.mit.edu', } } } } @@ -190,17 +237,20 @@ describe 'apt' do :server => 'subkeys.pgp.net', })} - it { is_expected.to contain_apt__key('4BD6EC30').with({ + it { is_expected.to contain_apt__key('EF8D349F').with({ :server => 'pgp.mit.edu', })} end context 'with ppas defined on valid osfamily' do let :facts do - { :osfamily => 'Debian', + { + :os => { :family => 'Debian', :name => 'Ubuntu', :release => { :major => '12', :full => '12.04.5' }}, + :osfamily => 'Debian', :lsbdistcodename => 'precise', :lsbdistid => 'ubuntu', - :puppetversion => '3.5.0', + :lsbdistrelease => '12.04', + :puppetversion => Puppet.version, } end let(:params) { { :ppas => { @@ -214,10 +264,12 @@ describe 'apt' do context 'with settings defined on valid osfamily' do let :facts do - { :osfamily => 'Debian', + { + :os => { :family => 'Debian', :name => 'Ubuntu', :release => { :major => '12', :full => '12.04.5' }}, + :osfamily => 'Debian', :lsbdistcodename => 'precise', :lsbdistid => 'Debian', - :puppetversion => '3.5.0', + :puppetversion => Puppet.version, } end let(:params) { { :settings => { @@ -229,6 +281,25 @@ describe 'apt' do it { is_expected.to contain_apt__setting('pref-banana')} end + context 'with pins defined on valid osfamily' do + let :facts do + { + :os => { :family => 'Debian', :name => 'Ubuntu', :release => { :major => '12', :full => '12.04.5' }}, + :osfamily => 'Debian', + :lsbdistcodename => 'precise', + :lsbdistid => 'Debian', + :puppetversion => Puppet.version, + } + end + let(:params) { { :pins => { + 'stable' => { 'priority' => 600, 'order' => 50 }, + 'testing' => { 'priority' => 700, 'order' => 100 }, + } } } + + it { is_expected.to contain_apt__pin('stable') } + it { is_expected.to contain_apt__pin('testing') } + end + describe 'failing tests' do context "purge['sources.list']=>'banana'" do let(:params) { { :purge => { 'sources.list' => 'banana' }, } } @@ -265,17 +336,5 @@ describe 'apt' do }.to raise_error(Puppet::Error) end end - - context 'with unsupported osfamily' do - let :facts do - { :osfamily => 'Darwin', :puppetversion => '3.5.0',} - end - - it do - expect { - subject.call - }.to raise_error(Puppet::Error, /This module only works on Debian or derivatives like Ubuntu/) - end - end end end