X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=manifests%2Fpin.pp;h=2ce81fd6bb292fce2eae61e60bf82b2e01bfa048;hb=60e50a9b65dec94fe20734404295e28d9e434a83;hp=39de3d8f1f688bbf1f79b5903c094558923efb07;hpb=2e206e31e4f01bd127cfebc7ee36cf5fd72def22;p=puppet-modules%2Fpuppetlabs-apt.git

diff --git a/manifests/pin.pp b/manifests/pin.pp
index 39de3d8..2ce81fd 100644
--- a/manifests/pin.pp
+++ b/manifests/pin.pp
@@ -3,7 +3,7 @@
 
 define apt::pin(
   $ensure          = present,
-  $explanation     = "${::caller_module_name}: ${name}",
+  $explanation     = "${caller_module_name}: ${name}",
   $order           = '',
   $packages        = '*',
   $priority        = 0,
@@ -31,13 +31,19 @@ define apt::pin(
     $release_version,
     $component,
     $originator,
-    $label] 
+    $label]
   $pin_release = join($pin_release_array, '')
 
   # Read the manpage 'apt_preferences(5)', especially the chapter
   # 'Thea Effect of APT Preferences' to understand the following logic
   # and the difference between specific and general form
-  if $packages != '*' { # specific form
+  if is_array($packages) {
+    $packages_string = join($packages, ' ')
+  } else {
+    $packages_string = $packages
+  }
+
+  if $packages_string != '*' { # specific form
 
     if ( $pin_release != '' and ( $origin != '' or $version != '' )) or
       ( $origin != '' and ( $pin_release != '' or $version != '' )) or
@@ -58,11 +64,21 @@ define apt::pin(
 
   }
 
+
+  # According to man 5 apt_preferences:
+  # The files have either no or "pref" as filename extension
+  # and only contain alphanumeric, hyphen (-), underscore (_) and period
+  # (.) characters. Otherwise APT will print a notice that it has ignored a
+  # file, unless that file matches a pattern in the
+  # Dir::Ignore-Files-Silently configuration list - in which case it will
+  # be silently ignored.
+  $file_name = regsubst($title, '[^0-9a-z\-_\.]', '_', 'IG')
+
   $path = $order ? {
-    ''      => "${preferences_d}/${name}.pref",
-    default => "${preferences_d}/${order}-${name}.pref",
+    ''      => "${preferences_d}/${file_name}.pref",
+    default => "${preferences_d}/${order}-${file_name}.pref",
   }
-  file { "${name}.pref":
+  file { "${file_name}.pref":
     ensure  => $ensure,
     path    => $path,
     owner   => root,