X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=manifests%2Fkey.pp;h=1933b3f9110b996e666208132e06188d1dc8c5a6;hb=a30791306b26a18d79875dbc1d99b11205802bcc;hp=31fc4859b594e108180ab226e2b4182673444df2;hpb=65b5e033550bd34cb394be664bc54cd93cb9c0a1;p=puppet-modules%2Fpuppetlabs-apt.git diff --git a/manifests/key.pp b/manifests/key.pp index 31fc485..1933b3f 100644 --- a/manifests/key.pp +++ b/manifests/key.pp @@ -8,14 +8,19 @@ define apt::key ( Optional[String] $options = undef, ) { - validate_re($id, ['\A(0x)?[0-9a-fA-F]{8}\Z', '\A(0x)?[0-9a-fA-F]{16}\Z', '\A(0x)?[0-9a-fA-F]{40}\Z']) + assert_type( + Pattern[ + /\A(0x)?[0-9a-fA-F]{8}\Z/, + /\A(0x)?[0-9a-fA-F]{16}\Z/, + /\A(0x)?[0-9a-fA-F]{40}\Z/, + ], $id) if $source { - validate_re($source, ['\Ahttps?:\/\/', '\Aftp:\/\/', '\A\/\w+']) + assert_type(Pattern[/\Ahttps?:\/\//, /\Aftp:\/\//, /\A\/\w+/], $source) } if $server { - validate_re($server,['\A((hkp|http|https):\/\/)?([a-z\d])([a-z\d-]{0,61}\.)+[a-z\d]+(:\d{2,5})?$']) + assert_type(Pattern[/\A((hkp|http|https):\/\/)?([a-z\d])([a-z\d-]{0,61}\.)+[a-z\d]+(:\d{2,5})?$/], $server) } case $ensure { @@ -36,17 +41,15 @@ define apt::key ( case $facts['os']['name'] { 'Debian': { - if versioncmp($facts['os']['release']['full'], '9.0') >= 0 { - AptKey<| title == $title |> { - require => Package['dirmngr'] - } + if versioncmp($facts['os']['release']['major'], '9') >= 0 { + ensure_packages(['dirmngr']) + Apt::Key<| title == $title |> } } 'Ubuntu': { if versioncmp($facts['os']['release']['full'], '17.04') >= 0 { - AptKey<| title == $title |> { - require => Package['dirmngr'] - } + ensure_packages(['dirmngr']) + Apt::Key<| title == $title |> } } default: { }