X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=.rubocop_todo.yml;h=da3cce5150029baef908b2e0fc5a880bcde3ee87;hb=refs%2Fheads%2Ftrusted-contributors;hp=b938048e16574bbf4b41dd5da884f2731c7496e0;hpb=88a921c82338c0116c3cadf0623e67f9dd899a3f;p=puppet-modules%2Fpuppetlabs-apt.git diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b938048..da3cce5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,84 +1,11 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-04-21 09:13:34 UTC using RuboCop version 1.48.1. +# on 2023-04-21 12:46:34 UTC using RuboCop version 1.48.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 32 -# This cop supports safe autocorrection (--autocorrect). -Layout/ClosingHeredocIndentation: - Exclude: - - 'spec/acceptance/apt_key_provider_spec.rb' - - 'spec/acceptance/apt_spec.rb' - - 'spec/spec_helper_acceptance_local.rb' - - 'spec/unit/puppet/provider/apt_key_spec.rb' - -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -Layout/EmptyLineAfterGuardClause: - Exclude: - - 'lib/facter/apt_updates.rb' - - 'lib/puppet/provider/apt_key/apt_key.rb' - - 'lib/puppet/type/apt_key.rb' - - 'spec/spec_helper_acceptance_local.rb' - - 'tasks/init.rb' - -# Offense count: 57 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. -# SupportedHashRocketStyles: key, separator, table -# SupportedColonStyles: key, separator, table -# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit -Layout/HashAlignment: - Exclude: - - 'spec/classes/apt_spec.rb' - - 'spec/classes/apt_update_spec.rb' - - 'spec/defines/conf_spec.rb' - - 'spec/defines/pin_spec.rb' - - 'spec/defines/source_compat_spec.rb' - - 'spec/defines/source_spec.rb' - - 'spec/unit/puppet/provider/apt_key_spec.rb' - - 'spec/unit/puppet/type/apt_key_spec.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Layout/HeredocIndentation: - Exclude: - - 'spec/spec_helper_acceptance_local.rb' - - 'spec/unit/puppet/provider/apt_key_spec.rb' - -# Offense count: 6 -# This cop supports safe autocorrection (--autocorrect). -Layout/SpaceAroundMethodCallOperator: - Exclude: - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/key_spec.rb' - -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -Lint/BooleanSymbol: - Exclude: - - 'spec/unit/puppet/type/apt_key_spec.rb' - -# Offense count: 3 -# Configuration parameters: AllowedMethods. -# AllowedMethods: enums -Lint/ConstantDefinitionInBlock: - Exclude: - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/source_compat_spec.rb' - - 'spec/defines/source_spec.rb' - -# Offense count: 6 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: strict, consistent -Lint/SymbolConversion: - Exclude: - - 'spec/classes/apt_update_spec.rb' - # Offense count: 6 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: @@ -105,119 +32,25 @@ Metrics/MethodLength: Metrics/PerceivedComplexity: Max: 12 -# Offense count: 1 -# Configuration parameters: MinSize. -Performance/CollectionLiteralInLoop: - Exclude: - - 'spec/classes/apt_update_spec.rb' - -# Offense count: 6 -# This cop supports unsafe autocorrection (--autocorrect-all). -RSpec/BeEq: - Exclude: - - 'spec/unit/facter/apt_reboot_required_spec.rb' - - 'spec/unit/puppet/type/apt_key_spec.rb' - -# Offense count: 8 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: be, be_nil -RSpec/BeNil: - Exclude: - - 'spec/unit/facter/apt_dist_package_security_updates_spec.rb' - - 'spec/unit/facter/apt_dist_package_updates_spec.rb' - - 'spec/unit/facter/apt_dist_security_updates_spec.rb' - - 'spec/unit/facter/apt_dist_updates_spec.rb' - - 'spec/unit/facter/apt_package_security_updates_spec.rb' - - 'spec/unit/facter/apt_package_updates_spec.rb' - - 'spec/unit/facter/apt_security_updates_spec.rb' - - 'spec/unit/facter/apt_updates_spec.rb' - -# Offense count: 6 -# Configuration parameters: Prefixes, AllowedPatterns. -# Prefixes: when, with, without -RSpec/ContextWording: - Exclude: - - 'spec/classes/apt_spec.rb' - - 'spec/classes/apt_update_spec.rb' - - 'spec/unit/puppet/provider/apt_key_spec.rb' - # Offense count: 32 # Configuration parameters: IgnoredMetadata. RSpec/DescribeClass: Enabled: false -# Offense count: 23 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowConsecutiveOneLiners. -RSpec/EmptyLineAfterExample: - Exclude: - - 'spec/acceptance/apt_key_provider_spec.rb' - - 'spec/acceptance/apt_spec.rb' - - 'spec/classes/apt_spec.rb' - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/key_spec.rb' - - 'spec/defines/pin_spec.rb' - - 'spec/defines/ppa_spec.rb' - - 'spec/defines/source_spec.rb' - -# Offense count: 39 -# This cop supports safe autocorrection (--autocorrect). -RSpec/EmptyLineAfterExampleGroup: - Exclude: - - 'spec/acceptance/apt_key_provider_spec.rb' - - 'spec/acceptance/init_task_spec.rb' - - 'spec/classes/apt_backports_spec.rb' - - 'spec/classes/apt_spec.rb' - - 'spec/classes/apt_update_spec.rb' - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/key_spec.rb' - - 'spec/defines/source_spec.rb' - -# Offense count: 24 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowConsecutiveOneLiners. -RSpec/EmptyLineAfterHook: - Exclude: - - 'spec/acceptance/apt_key_provider_spec.rb' - - 'spec/unit/facter/apt_dist_has_updates_spec.rb' - - 'spec/unit/facter/apt_dist_package_security_updates_spec.rb' - - 'spec/unit/facter/apt_dist_package_updates_spec.rb' - - 'spec/unit/facter/apt_dist_security_updates_spec.rb' - - 'spec/unit/facter/apt_dist_updates_spec.rb' - - 'spec/unit/facter/apt_has_updates_spec.rb' - - 'spec/unit/facter/apt_package_security_updates_spec.rb' - - 'spec/unit/facter/apt_package_updates_spec.rb' - - 'spec/unit/facter/apt_reboot_required_spec.rb' - - 'spec/unit/facter/apt_security_updates_spec.rb' - - 'spec/unit/facter/apt_updates_spec.rb' - - 'spec/unit/puppet/provider/apt_key_spec.rb' - # Offense count: 13 # Configuration parameters: CountAsOne. RSpec/ExampleLength: Max: 15 -# Offense count: 10 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples. -# DisallowedExamples: works -RSpec/ExampleWording: - Exclude: - - 'spec/acceptance/apt_key_provider_spec.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -RSpec/ExcessiveDocstringSpacing: - Exclude: - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/setting_spec.rb' +# Offense count: 3 +# Configuration parameters: AllowSubject. +RSpec/MultipleMemoizedHelpers: + Max: 6 # Offense count: 204 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit -RSpec/ImplicitSubject: +# Configuration parameters: EnforcedStyle, IgnoreSharedExamples. +# SupportedStyles: always, named_only +RSpec/NamedSubject: Exclude: - 'spec/classes/apt_backports_spec.rb' - 'spec/classes/apt_spec.rb' @@ -233,22 +66,6 @@ RSpec/ImplicitSubject: - 'spec/defines/source_spec.rb' - 'spec/unit/facter/apt_update_last_success_spec.rb' -# Offense count: 3 -RSpec/LeakyConstantDeclaration: - Exclude: - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/source_compat_spec.rb' - - 'spec/defines/source_spec.rb' - -# Offense count: 4 -RSpec/MultipleExpectations: - Max: 5 - -# Offense count: 3 -# Configuration parameters: AllowSubject. -RSpec/MultipleMemoizedHelpers: - Max: 6 - # Offense count: 2 # Configuration parameters: AllowedGroups. RSpec/NestedGroups: @@ -264,12 +81,6 @@ RSpec/NoExpectationExample: - 'spec/acceptance/apt_key_provider_spec.rb' - 'spec/acceptance/apt_spec.rb' -# Offense count: 4 -RSpec/RepeatedExampleGroupDescription: - Exclude: - - 'spec/acceptance/apt_spec.rb' - - 'spec/classes/apt_spec.rb' - # Offense count: 3 RSpec/StubbedMock: Exclude: @@ -280,78 +91,7 @@ Security/Open: Exclude: - 'lib/puppet/provider/apt_key/apt_key.rb' -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: MinBranchesCount. -Style/CaseLikeIf: - Exclude: - - 'lib/puppet/provider/apt_key/apt_key.rb' - -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -Style/GlobalStdStream: - Exclude: - - 'tasks/init.rb' - -# Offense count: 10 -# This cop supports safe autocorrection (--autocorrect). -Style/IfUnlessModifier: - Exclude: - - 'lib/facter/apt_updates.rb' - - 'lib/puppet/provider/apt_key/apt_key.rb' - - 'lib/puppet/type/apt_key.rb' - # Offense count: 1 Style/MixinUsage: Exclude: - 'spec/spec_helper.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: same_as_string_literals, single_quotes, double_quotes -Style/QuotedSymbols: - Exclude: - - 'spec/unit/puppet/provider/apt_key_spec.rb' - -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -Style/RedundantRegexpEscape: - Exclude: - - 'lib/puppet/type/apt_key.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: implicit, explicit -Style/RescueStandardError: - Exclude: - - 'spec/spec_helper.rb' - -# Offense count: 2 -# This cop supports unsafe autocorrection (--autocorrect-all). -Style/SlicingWithRange: - Exclude: - - 'lib/puppet/provider/apt_key/apt_key.rb' - -# Offense count: 338 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyleForMultiline. -# SupportedStylesForMultiline: comma, consistent_comma, no_comma -Style/TrailingCommaInHashLiteral: - Exclude: - - 'lib/puppet/provider/apt_key/apt_key.rb' - - 'spec/classes/apt_backports_spec.rb' - - 'spec/classes/apt_spec.rb' - - 'spec/classes/apt_update_spec.rb' - - 'spec/defines/conf_spec.rb' - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/key_spec.rb' - - 'spec/defines/mark_spec.rb' - - 'spec/defines/pin_spec.rb' - - 'spec/defines/ppa_spec.rb' - - 'spec/defines/setting_spec.rb' - - 'spec/defines/source_compat_spec.rb' - - 'spec/defines/source_spec.rb' - - 'spec/spec_helper.rb' - - 'spec/unit/puppet/provider/apt_key_spec.rb'