X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;f=.rubocop_todo.yml;h=da3cce5150029baef908b2e0fc5a880bcde3ee87;hb=refs%2Fheads%2Ftrusted-contributors;hp=69304c9545a9bcbfa8a944ef4987bafd092a9882;hpb=c7013c082891edae1543c6244f1f0719dae98d13;p=puppet-modules%2Fpuppetlabs-apt.git diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 69304c9..da3cce5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,110 +1,97 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2017-09-26 11:49:52 +0100 using RuboCop version 0.49.1. +# on 2023-04-21 12:46:34 UTC using RuboCop version 1.48.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent -Layout/IndentHeredoc: - Exclude: - - 'spec/acceptance/apt_key_provider_spec.rb' - - 'spec/unit/facter/apt_has_updates_spec.rb' - - 'spec/unit/facter/apt_package_security_updates_spec.rb' - - 'spec/unit/facter/apt_package_updates_spec.rb' - - 'spec/unit/facter/apt_security_updates_spec.rb' - - 'spec/unit/facter/apt_updates_spec.rb' +# Offense count: 6 +# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. +Metrics/AbcSize: + Max: 40 -# Offense count: 1 -Lint/HandleExceptions: - Exclude: - - 'spec/spec_helper.rb' +# Offense count: 3 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode. +# AllowedMethods: refine +Metrics/BlockLength: + Max: 180 -# Offense count: 8 -Lint/ParenthesesAsGroupedExpression: - Exclude: - - 'spec/classes/apt_backports_spec.rb' - - 'spec/classes/apt_update_spec.rb' +# Offense count: 3 +# Configuration parameters: AllowedMethods, AllowedPatterns. +Metrics/CyclomaticComplexity: + Max: 11 -# Offense count: 1 -Lint/RescueException: - Exclude: - - 'spec/spec_helper_acceptance.rb' +# Offense count: 8 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. +Metrics/MethodLength: + Max: 39 -# Offense count: 1 -Lint/ScriptPermission: - Exclude: - - 'spec/classes/apt_update_spec.rb' +# Offense count: 3 +# Configuration parameters: AllowedMethods, AllowedPatterns. +Metrics/PerceivedComplexity: + Max: 12 -# Offense count: 1 -Lint/UselessAssignment: - Exclude: - - 'spec/spec_helper_acceptance.rb' +# Offense count: 32 +# Configuration parameters: IgnoredMetadata. +RSpec/DescribeClass: + Enabled: false -# Offense count: 1 -# Configuration parameters: CustomIncludeMethods. -RSpec/EmptyExampleGroup: - Exclude: - - 'spec/defines/ppa_spec.rb' - -# Offense count: 51 -# Configuration parameters: Max. +# Offense count: 13 +# Configuration parameters: CountAsOne. RSpec/ExampleLength: - Exclude: - - 'spec/acceptance/apt_key_provider_spec.rb' - - 'spec/acceptance/apt_spec.rb' - - 'spec/classes/apt_spec.rb' - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/key_spec.rb' - - 'spec/unit/puppet/type/apt_key_spec.rb' + Max: 15 -# Offense count: 4 -RSpec/MultipleExpectations: - Max: 2 +# Offense count: 3 +# Configuration parameters: AllowSubject. +RSpec/MultipleMemoizedHelpers: + Max: 6 -# Offense count: 61 +# Offense count: 204 +# Configuration parameters: EnforcedStyle, IgnoreSharedExamples. +# SupportedStyles: always, named_only RSpec/NamedSubject: Exclude: - 'spec/classes/apt_backports_spec.rb' - 'spec/classes/apt_spec.rb' + - 'spec/classes/apt_update_spec.rb' - 'spec/defines/conf_spec.rb' - 'spec/defines/key_compat_spec.rb' - 'spec/defines/key_spec.rb' + - 'spec/defines/mark_spec.rb' - 'spec/defines/pin_spec.rb' - 'spec/defines/ppa_spec.rb' - 'spec/defines/setting_spec.rb' - 'spec/defines/source_compat_spec.rb' - 'spec/defines/source_spec.rb' + - 'spec/unit/facter/apt_update_last_success_spec.rb' -# Offense count: 4 -# Configuration parameters: Max. +# Offense count: 2 +# Configuration parameters: AllowedGroups. RSpec/NestedGroups: + Max: 4 + +# Offense count: 24 +# Configuration parameters: AllowedPatterns. +# AllowedPatterns: ^expect_, ^assert_ +RSpec/NoExpectationExample: Exclude: - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/key_spec.rb' + - 'spec/acceptance/01_apt_class_spec.rb' + - 'spec/acceptance/apt_backports_spec.rb' + - 'spec/acceptance/apt_key_provider_spec.rb' + - 'spec/acceptance/apt_spec.rb' # Offense count: 3 -RSpec/ScatteredLet: +RSpec/StubbedMock: Exclude: - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/key_spec.rb' + - 'spec/unit/puppet/provider/apt_key_spec.rb' -# Offense count: 1 -# Configuration parameters: MinBodyLength. -Style/GuardClause: +# Offense count: 2 +Security/Open: Exclude: - - 'spec/spec_helper_acceptance.rb' + - 'lib/puppet/provider/apt_key/apt_key.rb' -# Offense count: 15 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. -# SupportedStyles: slashes, percent_r, mixed -Style/RegexpLiteral: +# Offense count: 1 +Style/MixinUsage: Exclude: - - 'spec/classes/apt_spec.rb' - - 'spec/defines/source_compat_spec.rb' - - 'spec/defines/source_spec.rb' + - 'spec/spec_helper.rb'