X-Git-Url: https://review.fuel-infra.org/gitweb?a=blobdiff_plain;ds=sidebyside;f=manifests%2Fppa.pp;h=725170d2dc39dfb9c8b51841b795a8d467cb480c;hb=6283f6cf7214c17efe628858e98d28e5526c79fd;hp=75f0a69574368316f4540567d00b92383645391b;hpb=627718fd34e6610979edf0d36081678b80a390fd;p=puppet-modules%2Fpuppetlabs-apt.git

diff --git a/manifests/ppa.pp b/manifests/ppa.pp
index 75f0a69..725170d 100644
--- a/manifests/ppa.pp
+++ b/manifests/ppa.pp
@@ -1,13 +1,49 @@
 # ppa.pp
 
 define apt::ppa(
-	
+  $release = $::lsbdistcodename
 ) {
-	include apt
-	
-	exec { "/usr/bin/add-apt-repository ${name}":
-		require => Package["python-software-properties"],
-		# TODO: unless => 'check'
-	}
-}
+  include apt::params
+  include apt::update
+
+  $sources_list_d = $apt::params::sources_list_d
+
+  if ! $release {
+    fail('lsbdistcodename fact not available: release parameter required')
+  }
+
+  $filename_without_slashes = regsubst($name, '/', '-', G)
+  $filename_without_dots    = regsubst($filename_without_slashes, '\.', '_', G)
+  $filename_without_ppa     = regsubst($filename_without_dots, '^ppa:', '', G)
+  $sources_list_d_filename  = "${filename_without_ppa}-${release}.list"
+
+  $package = $::lsbdistrelease ? {
+    /^[1-9]\..*|1[01]\..*|12.04$/ => 'python-software-properties',
+    default  => 'software-properties-common',
+  }
 
+  if ! defined(Package[$package]) {
+    package { $package: }
+  }
+
+  exec { "add-apt-repository-${name}":
+    command   => "/usr/bin/add-apt-repository ${name}",
+    creates   => "${sources_list_d}/${sources_list_d_filename}",
+    logoutput => 'on_failure',
+    require   => [
+      File[$sources_list_d],
+      Package["${package}"],
+    ],
+    notify    => Exec['apt_update'],
+  }
+
+  file { "${sources_list_d}/${sources_list_d_filename}":
+    ensure  => file,
+    require => Exec["add-apt-repository-${name}"],
+  }
+
+  # Need anchor to provide containment for dependencies.
+  anchor { "apt::ppa::${name}":
+    require => Class['apt::update'],
+  }
+}