Merge pull request #706 from tphoney/rubocopification

[puppet-modules/puppetlabs-apt.git] / spec / unit / facter / apt_package_updates_spec.rb

diff --git a/spec/unit/facter/apt_package_updates_spec.rb b/spec/unit/facter/apt_package_updates_spec.rb
index dfa09270eb59d050a08812d4984846c040494efd..875a29005f9ee012fdecaa0a825cd9a19146f8d0 100644 (file)
--- a/spec/unit/facter/apt_package_updates_spec.rb
+++ b/spec/unit/facter/apt_package_updates_spec.rb
@@ -2,28 +2,36 @@ require 'spec_helper'
 
 describe 'apt_package_updates fact' do
   subject { Facter.fact(:apt_package_updates).value }
+
   after(:each) { Facter.clear }
 
-  describe 'on Debian based distro missing update-notifier-common' do
-    before { 
-    Facter.fact(:osfamily).stubs(:value).returns 'Debian'
-    File.stubs(:executable?).returns false
-  }
-  it { should == nil }
+  describe 'when apt has no updates' do
+    before(:each) do
+      Facter.fact(:apt_has_updates).stubs(:value).returns false
+    end
+    it { is_expected.to be nil }
   end
 
-  describe 'on Debian based distro' do
-    before { 
-    Facter.fact(:osfamily).stubs(:value).returns 'Debian'
-    File.stubs(:executable?).returns true
-    Facter::Util::Resolution.stubs(:exec).returns "puppet-common\nlinux-generic\nlinux-image-generic"
-  }
-  it {
-    if Facter.version < '2.0.0'
-      should == 'puppet-common,linux-generic,linux-image-generic'
-    else
-      should == ['puppet-common', 'linux-generic', 'linux-image-generic']
+  describe 'when apt has updates' do
+    before(:each) do
+      Facter.fact(:osfamily).stubs(:value).returns 'Debian'
+      File.stubs(:executable?) # Stub all other calls
+      Facter::Util::Resolution.stubs(:exec) # Catch all other calls
+      File.expects(:executable?).with('/usr/bin/apt-get').returns true
+      apt_output = <<-EOT
+Inst tzdata [2015f-0+deb8u1] (2015g-0+deb8u1 Debian:stable-updates [all])
+Conf tzdata (2015g-0+deb8u1 Debian:stable-updates [all])
+Inst unhide.rb [13-1.1] (22-2~bpo8+1 Debian Backports:jessie-backports [all])
+Conf unhide.rb (22-2~bpo8+1 Debian Backports:jessie-backports [all])
+EOT
+      Facter::Util::Resolution.expects(:exec).with('/usr/bin/apt-get -s -o Debug::NoLocking=true upgrade 2>&1').returns apt_output
     end
-  }
+    it {
+      if Facter.version < '2.0.0'
+        is_expected.to eq('tzdata,unhide.rb')
+      else
+        is_expected.to eq(['tzdata', 'unhide.rb'])
+      end
+    }
   end
 end