--- /dev/null
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+module MCollective
+ describe Discovery do
+ before do
+ Config.instance.stubs(:default_discovery_method).returns("mc")
+ @client = mock
+
+ Discovery.any_instance.stubs(:find_known_methods).returns(["mc"])
+ @discovery = Discovery.new(@client)
+ end
+
+ describe "#timeout_for_compound_filter" do
+ it "should return the correct time" do
+ ddl = mock
+ ddl.stubs(:meta).returns({:timeout => 1})
+
+ filter = [Matcher.create_compound_callstack("test().size=1 and rspec().size=1")]
+
+ DDL.expects(:new).with("test_data", :data).returns(ddl)
+ DDL.expects(:new).with("rspec_data", :data).returns(ddl)
+
+ @discovery.timeout_for_compound_filter(filter).should == 2
+ end
+ end
+
+ describe "#discover" do
+ before do
+ ddl = mock
+ ddl.stubs(:meta).returns({:timeout => 2})
+
+ discoverer = mock
+
+ @discovery.stubs(:force_discovery_method_by_filter).returns(false)
+ @discovery.stubs(:ddl).returns(ddl)
+ @discovery.stubs(:check_capabilities)
+ @discovery.stubs(:discovery_class).returns(discoverer)
+ end
+
+ it "should error for non fixnum limits" do
+ expect { @discovery.discover(nil, 0, 1.1) }.to raise_error("Limit has to be an integer")
+ end
+
+ it "should use the DDL timeout if none is specified" do
+ filter = Util.empty_filter
+ @discovery.discovery_class.expects(:discover).with(filter, 2, 0, @client)
+ @discovery.discover(filter, nil, 0)
+ end
+
+ it "should check the discovery method is capable of serving the filter" do
+ @discovery.expects(:check_capabilities).with("filter").raises("capabilities check failed")
+ expect { @discovery.discover("filter", nil, 0) }.to raise_error("capabilities check failed")
+ end
+
+ it "should call the correct discovery plugin" do
+ @discovery.discovery_class.expects(:discover).with("filter", 2, 0, @client)
+ @discovery.discover("filter", nil, 0)
+ end
+
+ it "should handle limits correctly" do
+ @discovery.discovery_class.stubs(:discover).returns([1,2,3,4,5])
+ @discovery.discover(Util.empty_filter, 1, 1).should == [1]
+ @discovery.discover(Util.empty_filter, 1, 0).should == [1,2,3,4,5]
+ end
+ end
+
+ describe "#force_discovery_method_by_filter" do
+ it "should force mc plugin when needed" do
+ options = {:discovery_method => "rspec"}
+
+ Log.expects(:info).with("Switching to mc discovery method because compound filters are used")
+
+ @discovery.expects(:discovery_method).returns("rspec")
+ @client.expects(:options).returns(options)
+ @discovery.force_discovery_method_by_filter({"compound" => ["rspec"]}).should == true
+
+ options[:discovery_method].should == "mc"
+ end
+
+ it "should not force mc plugin when no compound filter is used" do
+ options = {:discovery_method => "rspec"}
+
+ @discovery.expects(:discovery_method).returns("rspec")
+ @discovery.force_discovery_method_by_filter({"compound" => []}).should == false
+
+ options[:discovery_method].should == "rspec"
+ end
+ end
+
+ describe "#check_capabilities" do
+ before do
+ @ddl = mock
+ @discovery.stubs(:ddl).returns(@ddl)
+ @discovery.stubs(:discovery_method).returns("rspec")
+ end
+
+ it "should fail for unsupported capabilities" do
+ @ddl.stubs(:discovery_interface).returns({:capabilities => []})
+
+ filter = Util.empty_filter
+
+ expect { @discovery.check_capabilities(filter.merge({"cf_class" => ["filter"]})) }.to raise_error(/Cannot use class filters/)
+
+ ["fact", "identity", "compound"].each do |type|
+ expect { @discovery.check_capabilities(filter.merge({type => ["filter"]})) }.to raise_error(/Cannot use #{type} filters/)
+ end
+ end
+ end
+
+ describe "#ddl" do
+ before do
+ @ddl = mock
+ @ddl.stubs(:meta).returns({:name => "mc"})
+ end
+
+ it "should create an instance of the right ddl" do
+ @discovery.instance_variable_set("@ddl", nil)
+ @client.stubs(:options).returns({})
+ DDL.expects(:new).with("mc", :discovery).returns(@ddl)
+ @discovery.ddl
+ end
+
+ it "should reload the ddl if the method has changed" do
+ @discovery.instance_variable_set("@ddl", @ddl)
+ @discovery.stubs(:discovery_method).returns("rspec")
+ DDL.expects(:new).with("rspec", :discovery).returns(@ddl)
+ @discovery.ddl
+ end
+ end
+
+ describe "#discovery_class" do
+ it "should try to load the class if not already loaded" do
+ @discovery.expects(:discovery_method).returns("mc")
+ PluginManager.expects(:loadclass).with("MCollective::Discovery::Mc")
+ Discovery.expects(:const_defined?).with("Mc").returns(false)
+ Discovery.expects(:const_get).with("Mc").returns("rspec")
+ @discovery.discovery_class.should == "rspec"
+ end
+
+ it "should not load the class again if its already loaded" do
+ @discovery.expects(:discovery_method).returns("mc")
+ PluginManager.expects(:loadclass).never
+ Discovery.expects(:const_defined?).with("Mc").returns(true)
+ Discovery.expects(:const_get).with("Mc").returns("rspec")
+ @discovery.discovery_class.should == "rspec"
+ end
+ end
+
+ describe "#initialize" do
+ it "should load all the known methods" do
+ @discovery.instance_variable_get("@known_methods").should == ["mc"]
+ end
+ end
+
+ describe "#find_known_methods" do
+ it "should use the PluginManager to find plugins of type 'discovery'" do
+ @discovery.find_known_methods.should == ["mc"]
+ end
+ end
+
+ describe "#has_method?" do
+ it "should correctly report the availability of a discovery method" do
+ @discovery.has_method?("mc").should == true
+ @discovery.has_method?("rspec").should == false
+ end
+ end
+
+ describe "#descovery_method" do
+ it "should default to 'mc'" do
+ @client.expects(:options).returns({})
+ @discovery.discovery_method.should == "mc"
+ end
+
+ it "should give preference to the client options" do
+ @client.expects(:options).returns({:discovery_method => "rspec"}).twice
+ Config.instance.expects(:direct_addressing).returns(true)
+ @discovery.expects(:has_method?).with("rspec").returns(true)
+ @discovery.discovery_method.should == "rspec"
+ end
+
+ it "should validate the discovery method exists" do
+ @client.expects(:options).returns({:discovery_method => "rspec"}).twice
+ expect { @discovery.discovery_method.should == "rspec" }.to raise_error("Unknown discovery method rspec")
+ end
+
+ it "should only allow custom discovery methods if direct_addressing is enabled" do
+ @client.expects(:options).returns({:discovery_method => "rspec"}).twice
+ Config.instance.expects(:direct_addressing).returns(false)
+ @discovery.expects(:has_method?).with("rspec").returns(true)
+ expect { @discovery.discovery_method.should == "rspec" }.to raise_error("Custom discovery methods require direct addressing mode")
+ end
+ end
+ end
+end
Code Review / packages / precise / mcollective.git / blobdiff