+# frozen_string_literal: true
+
require 'spec_helper'
-describe 'apt::key', :type => :define do
- let(:facts) { { :lsbdistid => 'Debian' } }
- GPG_KEY_ID = '47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30'
+def contains_apt_key_example(title)
+ { id: title,
+ ensure: 'present',
+ source: 'http://apt.puppetlabs.com/pubkey.gpg',
+ server: 'pgp.mit.edu',
+ content: params[:content],
+ options: 'debug' }
+end
+
+def apt_key_example(title)
+ { id: title,
+ ensure: 'present',
+ source: nil,
+ server: 'keyserver.ubuntu.com',
+ content: nil,
+ keyserver_options: nil }
+end
+
+describe 'apt::key', type: :define do
+ GPG_KEY_ID = '6F6B15509CF8E59E6E469F327F438280EF8D349F'
+
+ let(:facts) do
+ {
+ os: {
+ family: 'Debian',
+ name: 'Debian',
+ release: {
+ major: '8',
+ full: '8.0',
+ },
+ distro: {
+ codename: 'jessie',
+ id: 'Debian',
+ },
+ },
+ }
+ end
let :title do
GPG_KEY_ID
end
+ let :pre_condition do
+ 'include apt'
+ end
+
describe 'normal operation' do
describe 'default options' do
- it 'contains the apt_key' do
- should contain_apt_key(title).with({
- :id => title,
- :ensure => 'present',
- :source => nil,
- :server => nil,
- :content => nil,
- :keyserver_options => nil,
- })
- end
+ it {
+ is_expected.to contain_apt_key(title).with(id: title,
+ ensure: 'present',
+ source: nil,
+ server: 'keyserver.ubuntu.com',
+ content: nil)
+ }
it 'contains the apt_key present anchor' do
- should contain_anchor("apt_key #{title} present")
+ is_expected.to contain_anchor("apt_key #{title} present")
end
end
'puppetlabs'
end
- let :params do {
- :key => GPG_KEY_ID,
- } end
+ let :params do
+ {
+ id: GPG_KEY_ID,
+ }
+ end
it 'contains the apt_key' do
- should contain_apt_key(title).with({
- :id => GPG_KEY_ID,
- :ensure => 'present',
- :source => nil,
- :server => nil,
- :content => nil,
- :keyserver_options => nil,
- })
+ is_expected.to contain_apt_key(title).with(id: GPG_KEY_ID,
+ ensure: 'present',
+ source: nil,
+ server: 'keyserver.ubuntu.com',
+ content: nil)
end
it 'contains the apt_key present anchor' do
- should contain_anchor("apt_key #{GPG_KEY_ID} present")
+ is_expected.to contain_anchor("apt_key #{GPG_KEY_ID} present")
end
end
describe 'ensure => absent' do
- let :params do {
- :ensure => 'absent',
- } end
+ let :params do
+ {
+ ensure: 'absent',
+ }
+ end
it 'contains the apt_key' do
- should contain_apt_key(title).with({
- :id => title,
- :ensure => 'absent',
- :source => nil,
- :server => nil,
- :content => nil,
- :keyserver_options => nil,
- })
+ is_expected.to contain_apt_key(title).with(id: title,
+ ensure: 'absent',
+ source: nil,
+ server: 'keyserver.ubuntu.com',
+ content: nil)
end
it 'contains the apt_key absent anchor' do
- should contain_anchor("apt_key #{title} absent")
+ is_expected.to contain_anchor("apt_key #{title} absent")
end
end
describe 'set a bunch of things!' do
- let :params do {
- :key_content => 'GPG key content',
- :key_source => 'http://apt.puppetlabs.com/pubkey.gpg',
- :key_server => 'pgp.mit.edu',
- :key_options => 'debug',
- } end
+ let :params do
+ {
+ content: 'GPG key content',
+ source: 'http://apt.puppetlabs.com/pubkey.gpg',
+ server: 'pgp.mit.edu',
+ options: 'debug',
+ }
+ end
it 'contains the apt_key' do
- should contain_apt_key(title).with({
- :id => title,
- :ensure => 'present',
- :source => 'http://apt.puppetlabs.com/pubkey.gpg',
- :server => 'pgp.mit.edu',
- :content => params[:key_content],
- :options => 'debug',
- })
+ is_expected.to contain_apt_key(title).with(contains_apt_key_example(title))
end
it 'contains the apt_key present anchor' do
- should contain_anchor("apt_key #{title} present")
+ is_expected.to contain_anchor("apt_key #{title} present")
end
end
- context "domain with dash" do
- let(:params) do{
- :key_server => 'p-gp.m-it.edu',
- } end
+ context 'when domain has dash' do
+ let(:params) do
+ {
+ server: 'p-gp.m-it.edu',
+ }
+ end
+
it 'contains the apt_key' do
- should contain_apt_key(title).with({
- :id => title,
- :server => 'p-gp.m-it.edu',
- })
+ is_expected.to contain_apt_key(title).with(id: title,
+ server: 'p-gp.m-it.edu')
end
end
- context "url" do
+ context 'with url' do
let :params do
{
- :key_server => 'hkp://pgp.mit.edu',
+ server: 'hkp://pgp.mit.edu',
}
end
+
it 'contains the apt_key' do
- should contain_apt_key(title).with({
- :id => title,
- :server => 'hkp://pgp.mit.edu',
- })
+ is_expected.to contain_apt_key(title).with(id: title,
+ server: 'hkp://pgp.mit.edu')
end
end
- context "url with port number" do
+ context 'with url and port number' do
let :params do
{
- :key_server => 'hkp://pgp.mit.edu:80',
+ server: 'hkp://pgp.mit.edu:80',
}
end
+
it 'contains the apt_key' do
- should contain_apt_key(title).with({
- :id => title,
- :server => 'hkp://pgp.mit.edu:80',
- })
+ is_expected.to contain_apt_key(title).with(id: title,
+ server: 'hkp://pgp.mit.edu:80')
end
end
end
describe 'validation' do
- context "domain begin with dash" do
- let(:params) do{
- :key_server => '-pgp.mit.edu',
- } end
+ context 'when domain begins with a dash' do
+ let(:params) do
+ {
+ server: '-pgp.mit.edu',
+ }
+ end
+
it 'fails' do
- expect { subject.call } .to raise_error(/does not match/)
+ is_expected .to raise_error(%r{expects a match})
end
end
- context "domain begin with dot" do
- let(:params) do{
- :key_server => '.pgp.mit.edu',
- } end
+ context 'when domain begins with dot' do
+ let(:params) do
+ {
+ server: '.pgp.mit.edu',
+ }
+ end
+
it 'fails' do
- expect { subject.call } .to raise_error(/does not match/)
+ is_expected .to raise_error(%r{expects a match})
end
end
- context "domain end with dot" do
- let(:params) do{
- :key_server => "pgp.mit.edu.",
- } end
+ context 'when domain ends with dot' do
+ let(:params) do
+ {
+ server: 'pgp.mit.edu.',
+ }
+ end
+
it 'fails' do
- expect { subject.call } .to raise_error(/does not match/)
+ is_expected .to raise_error(%r{expects a match})
end
end
- context "exceed character url" do
+ context 'when url character limit is exceeded' do
let :params do
{
- :key_server => 'hkp://pgpiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii.mit.edu'
+ server: 'hkp://pgpiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii.mit.edu',
}
end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context "incorrect port number url" do
+ context 'with incorrect port number url' do
let :params do
{
- :key_server => 'hkp://pgp.mit.edu:8008080'
+ server: 'hkp://pgp.mit.edu:8008080',
}
end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context "incorrect protocol for url" do
+ context 'with incorrect protocol for url' do
let :params do
{
- :key_server => 'abc://pgp.mit.edu:80'
+ server: 'abc://pgp.mit.edu:80',
}
end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context "missing port number url" do
+ context 'with missing port number url' do
let :params do
{
- :key_server => 'hkp://pgp.mit.edu:'
+ server: 'hkp://pgp.mit.edu:',
}
end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context "url ending with a dot" do
+ context 'with url ending with a dot' do
let :params do
{
- :key_server => 'hkp://pgp.mit.edu.'
+ server: 'hkp://pgp.mit.edu.',
}
end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context "url begin with a dash" do
- let(:params) do{
- :key_server => "hkp://-pgp.mit.edu",
- } end
+ context 'with url begin with a dash' do
+ let(:params) do
+ {
+ server: 'hkp://-pgp.mit.edu',
+ }
+ end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context 'invalid key' do
+ context 'with invalid key' do
let :title do
'Out of rum. Why? Why are we out of rum?'
end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context 'invalid source' do
- let :params do {
- :key_source => 'afp://puppetlabs.com/key.gpg',
- } end
+ context 'with invalid source' do
+ let :params do
+ {
+ source: 'afp://puppetlabs.com/key.gpg',
+ }
+ end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{evaluating a Resource})
end
end
- context 'invalid content' do
- let :params do {
- :key_content => [],
- } end
+ context 'with invalid content' do
+ let :params do
+ {
+ content: [],
+ }
+ end
+
it 'fails' do
- expect { subject.call }.to raise_error(/is not a string/)
+ is_expected.to raise_error(%r{expects a})
end
end
- context 'invalid server' do
- let :params do {
- :key_server => 'two bottles of rum',
- } end
+ context 'with invalid server' do
+ let :params do
+ {
+ server: 'two bottles of rum',
+ }
+ end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{expects a match})
end
end
- context 'invalid keyserver_options' do
- let :params do {
- :key_options => {},
- } end
+ context 'with invalid keyserver_options' do
+ let :params do
+ {
+ options: {},
+ }
+ end
+
it 'fails' do
- expect { subject.call }.to raise_error(/is not a string/)
+ is_expected.to raise_error(%r{expects a})
end
end
- context 'invalid ensure' do
+ context 'with invalid ensure' do
let :params do
{
- :ensure => 'foo',
+ ensure: 'foo',
}
end
+
it 'fails' do
- expect { subject.call }.to raise_error(/does not match/)
+ is_expected.to raise_error(%r{Enum\['absent', 'present', 'refreshed'\]})
end
end
- describe 'duplication' do
- context 'two apt::key resources for same key, different titles' do
- let :pre_condition do
- "apt::key { 'duplicate': key => '#{title}', }"
- end
-
- it 'contains two apt::key resources' do
- should contain_apt__key('duplicate').with({
- :key => title,
- :ensure => 'present',
- })
- should contain_apt__key(title).with({
- :id => title,
- :ensure => 'present',
- })
- end
-
- it 'contains only a single apt_key' do
- should contain_apt_key('duplicate').with({
- :id => title,
- :ensure => 'present',
- :source => nil,
- :server => nil,
- :content => nil,
- :keyserver_options => nil,
- })
- should_not contain_apt_key(title)
- end
- end
-
- context 'two apt::key resources, different ensure' do
- let :pre_condition do
- "apt::key { 'duplicate': key => '#{title}', ensure => 'absent', }"
- end
- it 'informs the user of the impossibility' do
- expect { subject.call }.to raise_error(/already ensured as absent/)
- end
+ describe 'duplication - two apt::key resources for same key, different titles' do
+ let :pre_condition do
+ "#{super()}\napt::key { 'duplicate': id => '#{title}', }"
+ end
+
+ it 'contains the duplicate apt::key resource' do
+ is_expected.to contain_apt__key('duplicate').with(id: title,
+ ensure: 'present')
+ end
+
+ it 'contains the original apt::key resource' do
+ is_expected.to contain_apt__key(title).with(id: title,
+ ensure: 'present')
+ end
+
+ it 'contains the native apt_key' do
+ is_expected.to contain_apt_key('duplicate').with(apt_key_example(title))
+ end
+
+ it 'does not contain the original apt_key' do
+ is_expected.not_to contain_apt_key(title)
+ end
+ end
+
+ describe 'duplication - two apt::key resources, different ensure' do
+ let :pre_condition do
+ "#{super()}\napt::key { 'duplicate': id => '#{title}', ensure => 'absent', }"
+ end
+
+ it 'informs the user of the impossibility' do
+ is_expected.to raise_error(%r{already ensured as absent})
end
end
end
Code Review / puppet-modules / puppetlabs-apt.git / blobdiff