(CONT-773) Rubocop Auto Fixes 1-5

[puppet-modules/puppetlabs-apt.git] / spec / defines / conf_spec.rb

diff --git a/spec/defines/conf_spec.rb b/spec/defines/conf_spec.rb
index f0192d61c414b067c474450ec4c87afd61ea3f16..04551b8e5dfe326668428cc4009534d281cd8630 100644 (file)
--- a/spec/defines/conf_spec.rb
+++ b/spec/defines/conf_spec.rb
@@ -1,65 +1,97 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
-describe 'apt::conf', :type => :define do
+describe 'apt::conf', type: :define do
   let :pre_condition do
     'class { "apt": }'
   end
-  let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy', :puppetversion   => Puppet.version, } }
+  let(:facts) do
+    {
+      os: {
+        family: 'Debian',
+        name: 'Debian',
+        release: {
+          major: '9',
+          full: '9.0',
+        },
+        distro: {
+          codename: 'stretch',
+          id: 'Debian',
+        },
+      },
+    }
+  end
   let :title do
     'norecommends'
   end
 
-  describe "when creating an apt preference" do
-    let :params do
+  describe 'when creating an apt preference' do
+    let :default_params do
       {
-        :priority => '00',
-        :content  => "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n"
+        priority: '00',
+        content: "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n",
       }
     end
+    let :params do
+      default_params
+    end
 
     let :filename do
-      "/etc/apt/apt.conf.d/00norecommends"
+      '/etc/apt/apt.conf.d/00norecommends'
     end
 
-    it { is_expected.to contain_file(filename).with({
-          'ensure'    => 'present',
-          'content'   => /Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;/,
-          'owner'     => 'root',
-          'group'     => 'root',
-          'mode'      => '0644',
-        })
-      }
+    it {
+      is_expected.to contain_file(filename).with('ensure' => 'present',
+                                                 'content' => %r{Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;},
+                                                 'owner' => 'root',
+                                                 'group' => 'root')
+    }
+
+    context 'with notify_update = true (default)' do
+      let :params do
+        default_params
+      end
+
+      it { is_expected.to contain_apt__setting("conf-#{title}").with_notify_update(true) }
+    end
+
+    context 'with notify_update = false' do
+      let :params do
+        default_params.merge(notify_update: false)
+      end
+
+      it { is_expected.to contain_apt__setting("conf-#{title}").with_notify_update(false) }
+    end
   end
 
-  describe "when creating a preference without content" do
+  describe 'when creating a preference without content' do
     let :params do
       {
-        :priority => '00',
+        priority: '00',
       }
     end
 
     it 'fails' do
-      expect { subject.call } .to raise_error(/pass in content/)
+      is_expected.to raise_error(%r{pass in content})
     end
   end
 
-  describe "when removing an apt preference" do
+  describe 'when removing an apt preference' do
     let :params do
       {
-        :ensure   => 'absent',
-        :priority => '00',
+        ensure: 'absent',
+        priority: '00',
       }
     end
 
     let :filename do
-      "/etc/apt/apt.conf.d/00norecommends"
+      '/etc/apt/apt.conf.d/00norecommends'
     end
 
-    it { is_expected.to contain_file(filename).with({
-        'ensure'    => 'absent',
-        'owner'     => 'root',
-        'group'     => 'root',
-        'mode'      => '0644',
-      })
+    it {
+      is_expected.to contain_file(filename).with('ensure' => 'absent',
+                                                 'owner' => 'root',
+                                                 'group' => 'root')
     }
   end
 end