Cleanup via rubocop of ruby code
[puppet-modules/puppetlabs-apt.git] / spec / classes / apt_spec.rb
index a21e0443e2df715b221e712d9457607d26117611..e743a0db67ef99b40f5e13b68f362a0bea030c64 100644 (file)
 require 'spec_helper'
-describe 'apt', :type => :class do
-  let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian' } }
-  let :default_params do
+describe 'apt' do
+  let(:facts) do
     {
-      :disable_keys => :undef,
-      :always_apt_update => false,
-      :purge_sources_list => false,
-      :purge_sources_list_d => false,
+      os: { family: 'Debian', name: 'Debian', release: { major: '7', full: '7.0' } },
+      lsbdistid: 'Debian',
+      osfamily: 'Debian',
+      lsbdistcodename: 'wheezy',
+      puppetversion: Puppet.version,
     }
   end
 
-  [{},
-    {
-      :disable_keys => true,
-      :always_apt_update => true,
-      :proxy_host => true,
-      :proxy_port => '3128',
-      :purge_sources_list => true,
-      :purge_sources_list_d => true,
-    },
-    {
-      :purge_preferences   => true,
-      :purge_preferences_d => true,
-    },
-    {
-      :disable_keys => false
+  context 'defaults' do
+    it {
+      is_expected.to contain_file('sources.list').that_notifies('Class[Apt::Update]').only_with(ensure: 'file',
+                                                                                                path: '/etc/apt/sources.list',
+                                                                                                owner: 'root',
+                                                                                                group: 'root',
+                                                                                                mode: '0644',
+                                                                                                notify: 'Class[Apt::Update]')
     }
-  ].each do |param_set|
-    describe "when #{param_set == {} ? "using default" : "specifying"} class parameters" do
-      let :param_hash do
-        default_params.merge(param_set)
-      end
 
-      let :params do
-        param_set
-      end
+    it {
+      is_expected.to contain_file('sources.list.d').that_notifies('Class[Apt::Update]').only_with(ensure: 'directory',
+                                                                                                  path: '/etc/apt/sources.list.d',
+                                                                                                  owner: 'root',
+                                                                                                  group: 'root',
+                                                                                                  mode: '0644',
+                                                                                                  purge: false,
+                                                                                                  recurse: false,
+                                                                                                  notify: 'Class[Apt::Update]')
+    }
 
-      let :refresh_only_apt_update do
-        if param_hash[:always_apt_update]
-          false
-        else
-          true
-        end
-      end
+    it {
+      is_expected.to contain_file('preferences').that_notifies('Class[Apt::Update]').only_with(ensure: 'file',
+                                                                                               path: '/etc/apt/preferences',
+                                                                                               owner: 'root',
+                                                                                               group: 'root',
+                                                                                               mode: '0644',
+                                                                                               notify: 'Class[Apt::Update]')
+    }
+
+    it {
+      is_expected.to contain_file('preferences.d').that_notifies('Class[Apt::Update]').only_with(ensure: 'directory',
+                                                                                                 path: '/etc/apt/preferences.d',
+                                                                                                 owner: 'root',
+                                                                                                 group: 'root',
+                                                                                                 mode: '0644',
+                                                                                                 purge: false,
+                                                                                                 recurse: false,
+                                                                                                 notify: 'Class[Apt::Update]')
+    }
 
-      it { should contain_class("apt::params") }
+    it 'lays down /etc/apt/apt.conf.d/15update-stamp' do
+      is_expected.to contain_file('/etc/apt/apt.conf.d/15update-stamp').with(group: 'root',
+                                                                             mode: '0644',
+                                                                             owner: 'root').with_content(/APT::Update::Post-Invoke-Success \{"touch \/var\/lib\/apt\/periodic\/update-success-stamp 2>\/dev\/null \|\| true";\};/) # rubocop:disable Metrics/LineLength
+    end
+
+    it {
+      is_expected.to contain_exec('apt_update').with(refreshonly: 'true')
+    }
+
+    it { is_expected.not_to contain_apt__setting('conf-proxy') }
+  end
+
+  describe 'proxy=' do
+    context 'host=localhost' do
+      let(:params) { { proxy: { 'host' => 'localhost' } } }
 
       it {
-        if param_hash[:purge_sources_list]
-        should contain_file("sources.list").with({
-            'path'    => "/etc/apt/sources.list",
-            'ensure'  => "present",
-            'owner'   => "root",
-            'group'   => "root",
-            'mode'    => "0644",
-            "content" => "# Repos managed by puppet.\n"
-          })
-        else
-        should contain_file("sources.list").with({
-            'path'    => "/etc/apt/sources.list",
-            'ensure'  => "present",
-            'owner'   => "root",
-            'group'   => "root",
-            'mode'    => "0644",
-            'content' => nil
-          })
-        end
+        is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+          /Acquire::http::proxy "http:\/\/localhost:8080\/";/,
+        ).without_content(
+          %r{Acquire::https::proxy},
+        )
       }
+    end
+
+    context 'host=localhost and port=8180' do
+      let(:params) { { proxy: { 'host' => 'localhost', 'port' => 8180 } } }
+
       it {
-        if param_hash[:purge_sources_list_d]
-          should create_file("sources.list.d").with({
-            'path'    => "/etc/apt/sources.list.d",
-            'ensure'  => "directory",
-            'owner'   => "root",
-            'group'   => "root",
-            'purge'   => true,
-            'recurse' => true,
-            'notify'  => 'Exec[apt_update]'
-          })
-        else
-          should create_file("sources.list.d").with({
-            'path'    => "/etc/apt/sources.list.d",
-            'ensure'  => "directory",
-            'owner'   => "root",
-            'group'   => "root",
-            'purge'   => false,
-            'recurse' => false,
-            'notify'  => 'Exec[apt_update]'
-          })
-        end
+        is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+          /Acquire::http::proxy "http:\/\/localhost:8180\/";/,
+        ).without_content(
+          %r{Acquire::https::proxy},
+        )
       }
+    end
+
+    context 'host=localhost and https=true' do
+      let(:params) { { proxy: { 'host' => 'localhost', 'https' => true } } }
+
       it {
-        if param_hash[:purge_preferences]
-          should create_file('apt-preferences').with({
-            :ensure  => 'absent',
-            :path    => '/etc/apt/preferences',
-          })
-        else
-          should_not contain_file('apt-preferences')
-        end
+        is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+          /Acquire::http::proxy "http:\/\/localhost:8080\/";/,
+        ).with_content(
+          /Acquire::https::proxy "https:\/\/localhost:8080\/";/,
+        )
       }
+    end
+
+    context 'ensure=absent' do
+      let(:params) { { proxy: { 'ensure' => 'absent' } } }
 
       it {
-        if param_hash[:purge_preferences_d]
-          should create_file("preferences.d").with({
-            'path'    => "/etc/apt/preferences.d",
-            'ensure'  => "directory",
-            'owner'   => "root",
-            'group'   => "root",
-            'purge'   => true,
-            'recurse' => true,
-          })
-        else
-          should create_file("preferences.d").with({
-            'path'    => "/etc/apt/preferences.d",
-            'ensure'  => "directory",
-            'owner'   => "root",
-            'group'   => "root",
-            'purge'   => false,
-            'recurse' => false,
-          })
-        end
+        is_expected.to contain_apt__setting('conf-proxy').with(ensure: 'absent',
+                                                               priority: '01')
       }
+    end
+  end
+  context 'lots of non-defaults' do
+    let :params do
+      {
+        update: { 'frequency' => 'always', 'timeout' => 1, 'tries' => 3 },
+        purge: { 'sources.list' => false, 'sources.list.d' => false,
+                 'preferences' => false, 'preferences.d' => false },
+      }
+    end
 
-      it {
-        should contain_exec("apt_update").with({
-          'command'     => "/usr/bin/apt-get update",
-          'refreshonly' => refresh_only_apt_update
-        })
+    it {
+      is_expected.to contain_file('sources.list').with(content: nil)
+    }
+
+    it {
+      is_expected.to contain_file('sources.list.d').with(purge: false,
+                                                         recurse: false)
+    }
+
+    it {
+      is_expected.to contain_file('preferences').with(ensure: 'file')
+    }
+
+    it {
+      is_expected.to contain_file('preferences.d').with(purge: false,
+                                                        recurse: false)
+    }
+
+    it {
+      is_expected.to contain_exec('apt_update').with(refreshonly: false,
+                                                     timeout: 1,
+                                                     tries: 3)
+    }
+  end
+
+  context 'with sources defined on valid osfamily' do
+    let :facts do
+      { os: { family: 'Debian', name: 'Ubuntu', release: { major: '12', full: '12.04' } },
+        osfamily: 'Debian',
+        lsbdistcodename: 'precise',
+        lsbdistid: 'Ubuntu',
+        lsbdistrelease: '12.04',
+        puppetversion: Puppet.version }
+    end
+    let(:params) do
+      { sources: {
+        'debian_unstable' => {
+          'location'          => 'http://debian.mirror.iweb.ca/debian/',
+          'release'           => 'unstable',
+          'repos'             => 'main contrib non-free',
+          'key'               => { 'id' => '150C8614919D8446E01E83AF9AA38DCD55BE302B', 'server' => 'subkeys.pgp.net' },
+          'pin'               => '-10',
+          'include'           => { 'src' => true },
+        },
+        'puppetlabs' => {
+          'location' => 'http://apt.puppetlabs.com',
+          'repos'      => 'main',
+          'key'        => { 'id' => '6F6B15509CF8E59E6E469F327F438280EF8D349F', 'server' => 'pgp.mit.edu' },
+        },
+      } }
+    end
+
+    it {
+      is_expected.to contain_apt__setting('list-debian_unstable').with(ensure: 'present')
+    }
+
+    it { is_expected.to contain_file('/etc/apt/sources.list.d/debian_unstable.list').with_content(/^deb http:\/\/debian.mirror.iweb.ca\/debian\/ unstable main contrib non-free$/) }
+    it { is_expected.to contain_file('/etc/apt/sources.list.d/debian_unstable.list').with_content(/^deb-src http:\/\/debian.mirror.iweb.ca\/debian\/ unstable main contrib non-free$/) }
+
+    it {
+      is_expected.to contain_apt__setting('list-puppetlabs').with(ensure: 'present')
+    }
+
+    it { is_expected.to contain_file('/etc/apt/sources.list.d/puppetlabs.list').with_content(/^deb http:\/\/apt.puppetlabs.com precise main$/) }
+  end
+
+  context 'with confs defined on valid osfamily' do
+    let :facts do
+      {
+        os: { family: 'Debian', name: 'Ubuntu', release: { major: '12', full: '12.04.5' } },
+        osfamily: 'Debian',
+        lsbdistcodename: 'precise',
+        lsbdistid: 'Debian',
+        puppetversion: Puppet.version,
       }
+    end
+    let(:params) do
+      { confs: {
+        'foo' => {
+          'content' => 'foo',
+        },
+        'bar' => {
+          'content' => 'bar',
+        },
+      } }
+    end
 
-      it {
-        if param_hash[:disable_keys] == true
-          should create_file("99unauth").with({
-            'content' => "APT::Get::AllowUnauthenticated 1;\n",
-            'ensure'  => "present",
-            'path'    => "/etc/apt/apt.conf.d/99unauth"
-          })
-        elsif param_hash[:disable_keys] == false
-          should create_file("99unauth").with({
-            'ensure' => "absent",
-            'path'   => "/etc/apt/apt.conf.d/99unauth"
-          })
-        elsif param_hash[:disable_keys] != :undef
-          should_not create_file("99unauth").with({
-            'path'   => "/etc/apt/apt.conf.d/99unauth"
-          })
-        end
+    it {
+      is_expected.to contain_apt__conf('foo').with(content: 'foo')
+    }
+
+    it {
+      is_expected.to contain_apt__conf('bar').with(content: 'bar')
+    }
+  end
+
+  context 'with keys defined on valid osfamily' do
+    let :facts do
+      {
+        os: { family: 'Debian', name: 'Ubuntu', release: { major: '12', full: '12.04.5' } },
+        osfamily: 'Debian',
+        lsbdistcodename: 'precise',
+        lsbdistid: 'Debian',
+        puppetversion: Puppet.version,
+      }
+    end
+    let(:params) do
+      { keys: {
+        '55BE302B' => {
+          'server' => 'subkeys.pgp.net',
+        },
+        'EF8D349F' => {
+          'server' => 'pgp.mit.edu',
+        },
+      } }
+    end
+
+    it {
+      is_expected.to contain_apt__key('55BE302B').with(server: 'subkeys.pgp.net')
+    }
+
+    it {
+      is_expected.to contain_apt__key('EF8D349F').with(server: 'pgp.mit.edu')
+    }
+  end
+
+  context 'with ppas defined on valid osfamily' do
+    let :facts do
+      {
+        os: { family: 'Debian', name: 'Ubuntu', release: { major: '12', full: '12.04.5' } },
+        osfamily: 'Debian',
+        lsbdistcodename: 'precise',
+        lsbdistid: 'ubuntu',
+        lsbdistrelease: '12.04',
+        puppetversion: Puppet.version,
+      }
+    end
+    let(:params) do
+      { ppas: {
+        'ppa:drizzle-developers/ppa' => {},
+        'ppa:nginx/stable' => {},
+      } }
+    end
+
+    it { is_expected.to contain_apt__ppa('ppa:drizzle-developers/ppa') }
+    it { is_expected.to contain_apt__ppa('ppa:nginx/stable') }
+  end
+
+  context 'with settings defined on valid osfamily' do
+    let :facts do
+      {
+        os: { family: 'Debian', name: 'Ubuntu', release: { major: '12', full: '12.04.5' } },
+        osfamily: 'Debian',
+        lsbdistcodename: 'precise',
+        lsbdistid: 'Debian',
+        puppetversion: Puppet.version,
       }
-      describe 'when setting a proxy' do
-        it {
-          if param_hash[:proxy_host]
-            should contain_file('01proxy').with(
-              'path'    => '/etc/apt/apt.conf.d/01proxy',
-              'content' => "Acquire::http::Proxy \"http://#{param_hash[:proxy_host]}:#{param_hash[:proxy_port]}\";\n",
-              'notify'  => "Exec[apt_update]"
-            )
-          else
-            should contain_file('01proxy').with(
-              'path'    => '/etc/apt/apt.conf.d/01proxy',
-              'notify'  => 'Exec[apt_update]',
-              'ensure'  => 'absent'
-            )
-          end
-        }
+    end
+    let(:params) do
+      { settings: {
+        'conf-banana' => { 'content' => 'banana' },
+        'pref-banana' => { 'content' => 'banana' },
+      } }
+    end
+
+    it { is_expected.to contain_apt__setting('conf-banana') }
+    it { is_expected.to contain_apt__setting('pref-banana') }
+  end
+
+  context 'with pins defined on valid osfamily' do
+    let :facts do
+      {
+        os: { family: 'Debian', name: 'Ubuntu', release: { major: '12', full: '12.04.5' } },
+        osfamily: 'Debian',
+        lsbdistcodename: 'precise',
+        lsbdistid: 'Debian',
+        puppetversion: Puppet.version,
+      }
+    end
+    let(:params) do
+      { pins: {
+        'stable' => { 'priority' => 600, 'order' => 50 },
+        'testing' =>  { 'priority' => 700, 'order' => 100 },
+      } }
+    end
+
+    it { is_expected.to contain_apt__pin('stable') }
+    it { is_expected.to contain_apt__pin('testing') }
+  end
+
+  describe 'failing tests' do
+    context "purge['sources.list']=>'banana'" do
+      let(:params) { { purge: { 'sources.list' => 'banana' } } }
+
+      it do
+        expect {
+          subject.call
+        }.to raise_error(Puppet::Error)
+      end
+    end
+
+    context "purge['sources.list.d']=>'banana'" do
+      let(:params) { { purge: { 'sources.list.d' => 'banana' } } }
+
+      it do
+        expect {
+          subject.call
+        }.to raise_error(Puppet::Error)
+      end
+    end
+
+    context "purge['preferences']=>'banana'" do
+      let(:params) { { purge: { 'preferences' => 'banana' } } }
+
+      it do
+        expect {
+          subject.call
+        }.to raise_error(Puppet::Error)
+      end
+    end
+
+    context "purge['preferences.d']=>'banana'" do
+      let(:params) { { purge: { 'preferences.d' => 'banana' } } }
+
+      it do
+        expect {
+          subject.call
+        }.to raise_error(Puppet::Error)
       end
     end
   end