+# frozen_string_literal: true
+
require 'spec_helper'
sources_list = { ensure: 'file',
path: '/etc/apt/sources.list',
owner: 'root',
group: 'root',
- mode: '0444',
notify: 'Class[Apt::Update]' }
sources_list_d = { ensure: 'directory',
path: '/etc/apt/sources.list.d',
owner: 'root',
group: 'root',
- mode: '0555',
purge: false,
recurse: false,
notify: 'Class[Apt::Update]' }
path: '/etc/apt/preferences',
owner: 'root',
group: 'root',
- mode: '0444',
notify: 'Class[Apt::Update]' }
preferences_d = { ensure: 'directory',
path: '/etc/apt/preferences.d',
owner: 'root',
group: 'root',
- mode: '0555',
purge: false,
recurse: false,
notify: 'Class[Apt::Update]' }
path: '/etc/apt/apt.conf.d',
owner: 'root',
group: 'root',
- mode: '0644',
purge: false,
recurse: false,
notify: 'Class[Apt::Update]' }
describe 'apt' do
let(:facts) do
{
- os: { family: 'Debian', name: 'Debian', release: { major: '8', full: '8.0' } },
- lsbdistid: 'Debian',
- osfamily: 'Debian',
- lsbdistcodename: 'jessie',
+ os: {
+ family: 'Debian',
+ name: 'Debian',
+ release: {
+ major: '9',
+ full: '9.0',
+ },
+ distro: {
+ codename: 'stretch',
+ id: 'Debian',
+ },
+ },
}
end
it 'lays down /etc/apt/apt.conf.d/15update-stamp' do
is_expected.to contain_file('/etc/apt/apt.conf.d/15update-stamp').with(group: 'root',
- mode: '0444',
owner: 'root').with_content(
%r{APT::Update::Post-Invoke-Success {"touch /var/lib/apt/periodic/update-success-stamp 2>/dev/null || true";};},
)
is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
%r{Acquire::http::proxy "http://localhost:8080/";},
).without_content(
- %r{Acquire::https::proxy},
+ %r{Acquire::https::proxy },
+ )
+ }
+ end
+
+ context 'when host=localhost and per-host[proxyscope]=proxyhost' do
+ let(:params) { { proxy: { 'host' => 'localhost', 'perhost' => [{ 'scope' => 'proxyscope', 'host' => 'proxyhost' }] } } }
+
+ it {
+ is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+ %r{Acquire::http::proxy::proxyscope "http://proxyhost:8080/";},
+ )
+ }
+ end
+
+ context 'when host=localhost and per-host[proxyscope]=proxyhost:8081' do
+ let(:params) { { proxy: { 'host' => 'localhost', 'perhost' => [{ 'scope' => 'proxyscope', 'host' => 'proxyhost', 'port' => 8081 }] } } }
+
+ it {
+ is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+ %r{Acquire::http::proxy::proxyscope "http://proxyhost:8081/";},
+ )
+ }
+ end
+
+ context 'when host=localhost and per-host[proxyscope]=[https]proxyhost' do
+ let(:params) { { proxy: { 'host' => 'localhost', 'perhost' => [{ 'scope' => 'proxyscope', 'host' => 'proxyhost', 'https' => true }] } } }
+
+ it {
+ is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+ %r{Acquire::https::proxy::proxyscope "https://proxyhost:8080/";},
+ )
+ }
+ end
+
+ context 'when host=localhost and per-host[proxyscope]=[direct]' do
+ let(:params) { { proxy: { 'host' => 'localhost', 'perhost' => [{ 'scope' => 'proxyscope', 'direct' => true }] } } }
+
+ it {
+ is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+ %r{Acquire::http::proxy::proxyscope "DIRECT";},
+ )
+ }
+ end
+
+ context 'when host=localhost and per-host[proxyscope]=[https][direct]' do
+ let(:params) { { proxy: { 'host' => 'localhost', 'perhost' => [{ 'scope' => 'proxyscope', 'https' => true, 'direct' => true }] } } }
+
+ it {
+ is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+ %r{Acquire::https::proxy::proxyscope "DIRECT";},
+ )
+ }
+ end
+
+ context 'when host=localhost and per-host[proxyscope]=proxyhost and per-host[proxyscope2]=proxyhost2' do
+ let(:params) { { proxy: { 'host' => 'localhost', 'perhost' => [{ 'scope' => 'proxyscope', 'host' => 'proxyhost' }, { 'scope' => 'proxyscope2', 'host' => 'proxyhost2' }] } } }
+
+ it {
+ is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
+ %r{Acquire::http::proxy::proxyscope "http://proxyhost:8080/";},
+ ).with_content(
+ %r{Acquire::http::proxy::proxyscope2 "http://proxyhost2:8080/";},
)
}
end
is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
%r{Acquire::http::proxy "http://localhost:8180/";},
).without_content(
- %r{Acquire::https::proxy},
+ %r{Acquire::https::proxy },
)
}
end
}
end
+ context 'with lots of non-defaults' do
+ let :params do
+ {
+ update: { 'frequency' => 'always', 'timeout' => 1, 'tries' => 3 },
+ purge: { 'sources.list' => true, 'sources.list.d' => true,
+ 'preferences' => true, 'preferences.d' => true,
+ 'apt.conf.d' => true },
+ }
+ end
+
+ it {
+ is_expected.to contain_file('sources.list').with(content: "# Repos managed by puppet.\n")
+ }
+
+ it {
+ is_expected.to contain_file('sources.list.d').with(purge: true,
+ recurse: true)
+ }
+
+ it {
+ is_expected.to contain_file('preferences').with(ensure: 'absent')
+ }
+
+ it {
+ is_expected.to contain_file('preferences.d').with(purge: true,
+ recurse: true)
+ }
+
+ it {
+ is_expected.to contain_file('apt.conf.d').with(purge: true,
+ recurse: true)
+ }
+
+ it {
+ is_expected.to contain_exec('apt_update').with(refreshonly: false,
+ timeout: 1,
+ tries: 3)
+ }
+ end
+
+ context 'with defaults for sources_list_force' do
+ let :params do
+ {
+ update: { 'frequency' => 'always', 'timeout' => 1, 'tries' => 3 },
+ purge: { 'sources.list' => true },
+ sources_list_force: false,
+ }
+ end
+
+ it {
+ is_expected.to contain_file('sources.list').with(content: "# Repos managed by puppet.\n")
+ }
+ end
+
+ context 'with non defaults for sources_list_force' do
+ let :params do
+ {
+ update: { 'frequency' => 'always', 'timeout' => 1, 'tries' => 3 },
+ purge: { 'sources.list' => true },
+ sources_list_force: true,
+ }
+ end
+
+ it {
+ is_expected.to contain_file('sources.list').with(ensure: 'absent')
+ }
+ end
+
context 'with entries for /etc/apt/auth.conf' do
facts_hash = {
- 'Ubuntu 14.04' => {
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '14', full: '14.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'trusty',
- lsbdistid: 'Ubuntu',
- lsbdistrelease: '14.04',
- },
- 'Ubuntu 16.04' => {
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '16', full: '16.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'xenial',
- lsbdistid: 'Ubuntu',
- lsbdistrelease: '16.04',
- },
'Ubuntu 18.04' => {
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '18', full: '18.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'bionic',
- lsbdistid: 'Ubuntu',
- lsbdistrelease: '18.04',
- },
- 'Debian 7.0' => {
- os: { family: 'Debian', name: 'Debian', release: { major: '7', full: '7.0' } },
- lsbdistid: 'Debian',
- osfamily: 'Debian',
- lsbdistcodename: 'wheezy',
- },
- 'Debian 8.0' => {
- os: { family: 'Debian', name: 'Debian', release: { major: '8', full: '8.0' } },
- lsbdistid: 'Debian',
- osfamily: 'Debian',
- lsbdistcodename: 'jessie',
+ os: {
+ family: 'Debian',
+ name: 'Ubuntu',
+ release: {
+ major: '18',
+ full: '18.04',
+ },
+ distro: {
+ codename: 'bionic',
+ id: 'Ubuntu',
+ },
+ },
},
'Debian 9.0' => {
- os: { family: 'Debian', name: 'Debian', release: { major: '9', full: '9.0' } },
- lsbdistid: 'Debian',
- osfamily: 'Debian',
- lsbdistcodename: 'stretch',
+ os: {
+ family: 'Debian',
+ name: 'Debian',
+ release: {
+ major: '9',
+ full: '9.0',
+ },
+ distro: {
+ codename: 'stretch',
+ id: 'Debian',
+ },
+ },
},
'Debian 10.0' => {
- os: { family: 'Debian', name: 'Debian', release: { major: '10', full: '10.0' } },
- lsbdistid: 'Debian',
- osfamily: 'Debian',
- lsbdistcodename: 'buster',
+ os: {
+ family: 'Debian',
+ name: 'Debian',
+ release: {
+ major: '10',
+ full: '10.0',
+ },
+ distro: {
+ codename: 'buster',
+ id: 'Debian',
+ },
+ },
},
}
super().merge(manage_auth_conf: true)
end
- # Going forward starting with Ubuntu 16.04 and Debian 9.0
- # /etc/apt/auth.conf is owned by _apt. In previous versions it is
- # root.
- auth_conf_owner = case os
- when 'Ubuntu 14.04', 'Debian 7.0', 'Debian 8.0'
- 'root'
- else
- '_apt'
- end
-
auth_conf_content = "// This file is managed by Puppet. DO NOT EDIT.
machine deb.example.net login foologin password secret
machine apt.example.com login aptlogin password supersecret
it {
is_expected.to contain_file('/etc/apt/auth.conf').with(ensure: 'present',
- owner: auth_conf_owner,
+ owner: '_apt',
group: 'root',
- mode: '0400',
+ mode: '0600',
notify: 'Class[Apt::Update]',
- content: auth_conf_content)
+ content: sensitive(auth_conf_content))
}
end
end
end
- context 'with sources defined on valid osfamily' do
+ context 'with sources defined on valid os.family' do
let :facts do
{
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '16', full: '16.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'xenial',
- lsbdistid: 'Ubuntu',
- lsbdistrelease: '16.04',
+ os: {
+ family: 'Debian',
+ name: 'Ubuntu',
+ release: {
+ major: '18',
+ full: '18.04',
+ },
+ distro: {
+ codename: 'bionic',
+ id: 'Ubuntu',
+ },
+ },
}
end
let(:params) do
is_expected.to contain_apt__setting('list-puppetlabs').with(ensure: 'present')
}
- it { is_expected.to contain_file('/etc/apt/sources.list.d/puppetlabs.list').with_content(%r{^deb http://apt.puppetlabs.com xenial main$}) }
+ it { is_expected.to contain_file('/etc/apt/sources.list.d/puppetlabs.list').with_content(%r{^deb http://apt.puppetlabs.com bionic main$}) }
end
- context 'with confs defined on valid osfamily' do
+ context 'with confs defined on valid os.family' do
let :facts do
{
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '16', full: '16.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'xenial',
- lsbdistid: 'Ubuntu',
+ os: {
+ family: 'Debian',
+ name: 'Ubuntu',
+ release: {
+ major: '18',
+ full: '18.04',
+ },
+ distro: {
+ codename: 'bionic',
+ id: 'Ubuntu',
+ },
+ },
}
end
let(:params) do
}
end
- context 'with keys defined on valid osfamily' do
+ context 'with keys defined on valid os.family' do
let :facts do
{
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '16', full: '16.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'xenial',
- lsbdistid: 'Ubuntu',
+ os: {
+ family: 'Debian',
+ name: 'Ubuntu',
+ release: {
+ major: '18',
+ full: '18.04',
+ },
+ distro: {
+ codename: 'bionic',
+ id: 'Ubuntu',
+ },
+ },
}
end
let(:params) do
}
end
- context 'with ppas defined on valid osfamily' do
+ context 'with ppas defined on valid os.family' do
let :facts do
{
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '16', full: '16.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'xenial',
- lsbdistid: 'Ubuntu',
- lsbdistrelease: '16.04',
+ os: {
+ family: 'Debian',
+ name: 'Ubuntu',
+ release: {
+ major: '18',
+ full: '18.04',
+ },
+ distro: {
+ codename: 'bionic',
+ id: 'Ubuntu',
+ },
+ },
}
end
let(:params) do
it { is_expected.to contain_apt__ppa('ppa:nginx/stable') }
end
- context 'with settings defined on valid osfamily' do
+ context 'with settings defined on valid os.family' do
let :facts do
{
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '16', full: '16.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'xenial',
- lsbdistid: 'Ubuntu',
+ os: {
+ family: 'Debian',
+ name: 'Ubuntu',
+ release: {
+ major: '18',
+ full: '18.04',
+ },
+ distro: {
+ codename: 'bionic',
+ id: 'Ubuntu',
+ },
+ },
}
end
let(:params) do
it { is_expected.to contain_apt__setting('pref-banana') }
end
- context 'with pins defined on valid osfamily' do
+ context 'with pins defined on valid os.family' do
let :facts do
{
- os: { family: 'Debian', name: 'Ubuntu', release: { major: '16', full: '16.04' } },
- osfamily: 'Debian',
- lsbdistcodename: 'xenial',
- lsbdistid: 'Ubuntu',
+ os: {
+ family: 'Debian',
+ name: 'Ubuntu',
+ release: {
+ major: '18',
+ full: '18.04',
+ },
+ distro: {
+ codename: 'bionic',
+ id: 'Ubuntu',
+ },
+ },
}
end
let(:params) do