Merge pull request #55 from nanliu/tb/containment

[puppet-modules/puppetlabs-apt.git] / manifests / source.pp

diff --git a/manifests/source.pp b/manifests/source.pp
index 7dee0a985f4fa96f10cf73a5efdb5f21c0e96688..e55cafdfd1f4fbb493247f88b5a497270eec743e 100644 (file)
--- a/manifests/source.pp
+++ b/manifests/source.pp
@@ -2,48 +2,68 @@
 # add an apt source
 
 define apt::source(
-       $location = '',
-       $release = 'karmic',
-       $repos = 'main',
-       $include_src = true,
-       $required_packages = false,
-       $key = false,
-       $key_server = 'keyserver.ubuntu.com',
-       $pin = false
+  $ensure = present,
+  $location = '',
+  $release = $lsbdistcodename,
+  $repos = 'main',
+  $include_src = true,
+  $required_packages = false,
+  $key = false,
+  $key_server = 'keyserver.ubuntu.com',
+  $key_content = false,
+  $key_source  = false,
+  $pin = false
 ) {
 
-       file { "${name}.list":
-               ensure => file,
-               owner => root,
-               group => root,
-               mode => 644,
-               content => template("apt/source.list.erb"),
-       }
-
-       if $pin != false {
-               apt::pin { "${release}": priority => "${pin}" }
-       }
-
-       exec { "${name} apt update":
-               subscribe => File["${name}.list"],
-               refreshonly => true,
-       }
-
-       if $required_packages != false {
-                       subscribe => File["${name}.list"],
-                       refreshonly => true,
-               }
-       }
-
-       if $key != false {
-               exec { "/usr/bin/apt-key adv --keyserver ${key_server} --recv-keys ${key}":
-                       unless => "/usr/bin/apt-key list | grep ${key}",
-                       before => File["${name}.list"],
-               }
-       }
   include apt::params
+  include apt::update
 
-    name => "${apt::params::root}/sources.list.d/${name}.list",
-    command => "${apt::params::provider} update",
-    exec { "${apt::params::provider} -y install ${required_packages}":
+  $sources_list_d = $apt::params::sources_list_d
+  $provider       = $apt::params::provider
+
+  if $release == undef {
+    fail('lsbdistcodename fact not available: release parameter required')
+  }
+
+  file { "${name}.list":
+    ensure  => $ensure,
+    path    => "${sources_list_d}/${name}.list",
+    owner   => root,
+    group   => root,
+    mode    => '0644',
+    content => template("${module_name}/source.list.erb"),
+    notify  => Exec['apt_update'],
+  }
+
+  if ($pin != false) and ($ensure == 'present') {
+    apt::pin { $release:
+      priority => $pin,
+      before   => File["${name}.list"]
+    }
+  }
+
+  if ($required_packages != false) and ($ensure == 'present') {
+    exec { "Required packages: '${required_packages}' for ${name}":
+      command     => "${provider} -y install ${required_packages}",
+      subscribe   => File["${name}.list"],
+      refreshonly => true,
+    }
+  }
+
+  # We do not want to remove keys when the source is absent.
+  if ($key != false) and ($ensure == 'present') {
+    apt::key { "Add key: ${key} from Apt::Source ${title}":
+      ensure      => present,
+      key         => $key,
+      key_server  => $key_server,
+      key_content => $key_content,
+      key_source  => $key_source,
+      before      => File["${name}.list"],
+    }
+  }
+
+  # Need anchor to provide containment for dependencies.
+  anchor { "apt::source::${name}":
+    require => Class['apt::update'],
+  }
 }