Make apt::setting notify Exec['apt_update'] by default

[puppet-modules/puppetlabs-apt.git] / manifests / source.pp

diff --git a/manifests/source.pp b/manifests/source.pp
index 04c367119ac941d626c2a430409f650bb81b6a18..b7d150c2233b8448710f7690315606e9bef4e461 100644 (file)
--- a/manifests/source.pp
+++ b/manifests/source.pp
@@ -1,54 +1,33 @@
 # source.pp
 # add an apt source
-
 define apt::source(
   $comment           = $name,
   $ensure            = present,
   $location          = '',
-  $release           = 'UNDEF',
+  $release           = $::lsbdistcodename,
   $repos             = 'main',
-  $include_src       = true,
+  $include_src       = false,
   $include_deb       = true,
-  $required_packages = false,
   $key               = undef,
   $key_server        = 'keyserver.ubuntu.com',
   $key_content       = undef,
   $key_source        = undef,
   $pin               = false,
   $architecture      = undef,
-  $trusted           = false,
+  $trusted_source    = false,
 ) {
+  validate_string($architecture, $comment, $location, $release, $repos, $key_server)
+  validate_bool($trusted_source, $include_src, $include_deb)
 
-  include apt::params
-  include apt::update
-
-  validate_string($architecture)
-  validate_bool($trusted)
-
-  $sources_list_d = $apt::params::sources_list_d
-  $provider       = $apt::params::provider
-
-  if $release == 'UNDEF' {
-    if $::lsbdistcodename == undef {
-      fail('lsbdistcodename fact not available: release parameter required')
-    } else {
-      $release_real = $::lsbdistcodename
-    }
-  } else {
-    $release_real = $release
+  if ! $release {
+    fail('lsbdistcodename fact not available: release parameter required')
   }
 
-  file { "${name}.list":
+  apt::setting { "list-${name}":
     ensure  => $ensure,
-    path    => "${sources_list_d}/${name}.list",
-    owner   => root,
-    group   => root,
-    mode    => '0644',
-    content => template("${module_name}/source.list.erb"),
-    notify  => Exec['apt_update'],
+    content => template('apt/_header.erb', 'apt/source.list.erb'),
   }
 
-
   if ($pin != false) {
     # Get the host portion out of the url so we can pin to origin
     $url_split = split($location, '/')
@@ -57,23 +36,11 @@ define apt::source(
     apt::pin { $name:
       ensure   => $ensure,
       priority => $pin,
-      before   => File["${name}.list"],
+      before   => Apt::Setting["list-${name}"],
       origin   => $host,
     }
   }
 
-  if ($required_packages != false) and ($ensure == 'present') {
-    exec { "Required packages: '${required_packages}' for ${name}":
-      command     => "${provider} -y install ${required_packages}",
-      logoutput   => 'on_failure',
-      refreshonly => true,
-      tries       => 3,
-      try_sleep   => 1,
-      subscribe   => File["${name}.list"],
-      before      => Exec['apt_update'],
-    }
-  }
-
   # We do not want to remove keys when the source is absent.
   if $key and ($ensure == 'present') {
     apt::key { "Add key: ${key} from Apt::Source ${title}":
@@ -82,12 +49,7 @@ define apt::source(
       key_server  => $key_server,
       key_content => $key_content,
       key_source  => $key_source,
-      before      => File["${name}.list"],
+      before      => Apt::Setting["list-${name}"],
     }
   }
-
-  # Need anchor to provide containment for dependencies.
-  anchor { "apt::source::${name}":
-    require => Class['apt::update'],
-  }
 }