Modify apt::source release parameter test

[puppet-modules/puppetlabs-apt.git] / manifests / source.pp

diff --git a/manifests/source.pp b/manifests/source.pp
index b6e8476b4cff5b33fa4780dff45d4cf2a181ec00..42a21e9e49c3293a80886a75c7dc67e4cb43e1d1 100644 (file)
--- a/manifests/source.pp
+++ b/manifests/source.pp
@@ -3,20 +3,25 @@
 
 define apt::source(
   $location = '',
-  $release = 'karmic',
+  $release = $lsbdistcodename,
   $repos = 'main',
   $include_src = true,
   $required_packages = false,
   $key = false,
   $key_server = 'keyserver.ubuntu.com',
+  $key_content = false,
+  $key_source  = false,
   $pin = false
 ) {
 
   include apt::params
 
+  if $release == undef {
+    fail("lsbdistcodename fact not available: release parameter required")
+  }
 
   file { "${name}.list":
-    name => "${apt::params::root}/sources.list.d/${name}.list",
+    path => "${apt::params::root}/sources.list.d/${name}.list",
     ensure => file,
     owner => root,
     group => root,
@@ -25,7 +30,7 @@ define apt::source(
   }
 
   if $pin != false {
-    apt::pin { "${release}": priority => "${pin}" }
+    apt::pin { "${release}": priority => "${pin}" } -> File["${name}.list"]
   }
 
   exec { "${name} apt update":
@@ -35,16 +40,21 @@ define apt::source(
   }
 
   if $required_packages != false {
-    exec { "${apt::params::provider} -y install ${required_packages}":
-      subscribe => File["${name}.list"],
+    exec { "Required packages: '${required_packages}' for ${name}":
+      command     => "${apt::params::provider} -y install ${required_packages}",
+      subscribe   => File["${name}.list"],
       refreshonly => true,
     }
   }
 
   if $key != false {
-    exec { "/usr/bin/apt-key adv --keyserver ${key_server} --recv-keys ${key}":
-      unless => "/usr/bin/apt-key list | grep ${key}",
-      before => File["${name}.list"],
+    apt::key { "Add key: ${key} from Apt::Source ${title}":
+      key         => $key,
+      ensure      => present,
+      key_server  => $key_server,
+      key_content => $key_content,
+      key_source  => $key_source,
+      before      => File["${name}.list"],
     }
   }
 }