Cleanup apt-module puppet-lint related issues.

[puppet-modules/puppetlabs-apt.git] / manifests / ppa.pp

diff --git a/manifests/ppa.pp b/manifests/ppa.pp
index e7ab361deecdaad1d9b9fdfa6880c85d40e37ed7..d27aca4442ee8253f19333e79f3449a2876d8b04 100644 (file)
--- a/manifests/ppa.pp
+++ b/manifests/ppa.pp
@@ -1,13 +1,37 @@
 # ppa.pp
 
 define apt::ppa(
-       
+  $release = $::lsbdistcodename
 ) {
-       include apt
-       
-       exec { "add-apt-repository ${name}":
-               require => Package["python-software-properties"],
-               # TODO: unless => 'check'
-       }
+
+  Class['apt'] -> Apt::Ppa[$title]
+
+  include apt::params
+
+  $sources_list_d = $apt::params::sources_list_d
+
+  if ! $release {
+    fail('lsbdistcodename fact not available: release parameter required')
+  }
+
+  exec { "apt-update-${name}":
+    command     => "${apt::params::provider} update",
+    refreshonly => true,
+  }
+
+  $filename_without_slashes = regsubst($name,'/','-','G')
+  $filename_without_ppa = regsubst($filename_without_slashes, '^ppa:','','G')
+  $sources_list_d_filename = "${filename_without_ppa}-${release}.list"
+
+  exec { "add-apt-repository-${name}":
+    command => "/usr/bin/add-apt-repository ${name}",
+    notify  => Exec["apt-update-${name}"],
+    creates => "${sources_list_d}/${sources_list_d_filename}",
+  }
+
+  file { "${sources_list_d}/${sources_list_d_filename}":
+    ensure  => file,
+    require => Exec["add-apt-repository-${name}"];
+  }
 }