Code Review
/
puppet-modules
/
puppetlabs-apt.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
(maint) Addressing puppet-lint doc warnings
[puppet-modules/puppetlabs-apt.git]
/
spec
/
defines
/
pin_spec.rb
diff --git
a/spec/defines/pin_spec.rb
b/spec/defines/pin_spec.rb
index a01a919a5b2e42636b49aa8a97460613a54f45ee..2329e9a318f70adb322180275136967d2968c2bd 100644
(file)
--- a/
spec/defines/pin_spec.rb
+++ b/
spec/defines/pin_spec.rb
@@
-14,11
+14,11
@@
describe 'apt::pin', type: :define do
end
let(:title) { 'my_pin' }
end
let(:title) { 'my_pin' }
- context 'defaults' do
+ context '
with
defaults' do
it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: \*\nPin: release a=my_pin\nPin-Priority: 0\n}) }
end
it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: \*\nPin: release a=my_pin\nPin-Priority: 0\n}) }
end
- context 'set version' do
+ context '
with
set version' do
let :params do
{
'packages' => 'vim',
let :params do
{
'packages' => 'vim',
@@
-29,7
+29,7
@@
describe 'apt::pin', type: :define do
it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: vim\nPin: version 1\nPin-Priority: 0\n}) }
end
it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: vim\nPin: version 1\nPin-Priority: 0\n}) }
end
- context 'set origin' do
+ context '
with
set origin' do
let :params do
{
'packages' => 'vim',
let :params do
{
'packages' => 'vim',
@@
-40,7
+40,7
@@
describe 'apt::pin', type: :define do
it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: vim\nPin: origin test\nPin-Priority: 0\n}) }
end
it { is_expected.to contain_apt__setting('pref-my_pin').with_content(%r{Explanation: : my_pin\nPackage: vim\nPin: origin test\nPin-Priority: 0\n}) }
end
- context '
no
t defaults' do
+ context '
withou
t defaults' do
let :params do
{
'explanation' => 'foo',
let :params do
{
'explanation' => 'foo',
@@
-61,7
+61,7
@@
describe 'apt::pin', type: :define do
}
end
}
end
- context 'ensure absent' do
+ context '
with
ensure absent' do
let :params do
{
'ensure' => 'absent',
let :params do
{
'ensure' => 'absent',
@@
-73,14
+73,14
@@
describe 'apt::pin', type: :define do
}
end
}
end
- context 'bad characters' do
+ context '
with
bad characters' do
let(:title) { 'such bad && wow!' }
it { is_expected.to contain_apt__setting('pref-such__bad____wow_') }
end
describe 'validation' do
let(:title) { 'such bad && wow!' }
it { is_expected.to contain_apt__setting('pref-such__bad____wow_') }
end
describe 'validation' do
- context 'invalid order' do
+ context '
with
invalid order' do
let :params do
{
'order' => 'foo',
let :params do
{
'order' => 'foo',
@@
-88,13
+88,11
@@
describe 'apt::pin', type: :define do
end
it do
end
it do
- expect {
- subject.call
- }.to raise_error(Puppet::Error, %r{expects an Integer value, got String})
+ is_expected.to raise_error(Puppet::Error, %r{expects an Integer value, got String})
end
end
end
end
- context 'packages == * and version' do
+ context '
with
packages == * and version' do
let :params do
{
'version' => '1',
let :params do
{
'version' => '1',
@@
-102,13
+100,11
@@
describe 'apt::pin', type: :define do
end
it do
end
it do
- expect {
- subject.call
- }.to raise_error(Puppet::Error, %r{parameter version cannot be used in general form})
+ is_expected.to raise_error(Puppet::Error, %r{parameter version cannot be used in general form})
end
end
end
end
- context 'packages == * and release and origin' do
+ context '
with
packages == * and release and origin' do
let :params do
{
'origin' => 'test',
let :params do
{
'origin' => 'test',
@@
-117,13
+113,11
@@
describe 'apt::pin', type: :define do
end
it do
end
it do
- expect {
- subject.call
- }.to raise_error(Puppet::Error, %r{parameters release and origin are mutually exclusive})
+ is_expected.to raise_error(Puppet::Error, %r{parameters release and origin are mutually exclusive})
end
end
end
end
- context '
specific form with
release and origin' do
+ context '
with specific
release and origin' do
let :params do
{
'release' => 'foo',
let :params do
{
'release' => 'foo',
@@
-133,13
+127,11
@@
describe 'apt::pin', type: :define do
end
it do
end
it do
- expect {
- subject.call
- }.to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
+ is_expected.to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
end
end
end
end
- context '
specific form with
version and origin' do
+ context '
with specific
version and origin' do
let :params do
{
'version' => '1',
let :params do
{
'version' => '1',
@@
-149,9
+141,7
@@
describe 'apt::pin', type: :define do
end
it do
end
it do
- expect {
- subject.call
- }.to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
+ is_expected.to raise_error(Puppet::Error, %r{parameters release, origin, and version are mutually exclusive})
end
end
end
end
end
end