Code Review
/
puppet-modules
/
puppetlabs-apt.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge pull request #1085 from puppetlabs/CONT-493-ppa_validation_fix
[puppet-modules/puppetlabs-apt.git]
/
spec
/
defines
/
mark_spec.rb
diff --git
a/spec/defines/mark_spec.rb
b/spec/defines/mark_spec.rb
index 6c673c41c36ae4fbd48470daba9a2f8acedfadef..5375fe236f4e8c9ca3eb7cc564373f40372837ef 100644
(file)
--- a/
spec/defines/mark_spec.rb
+++ b/
spec/defines/mark_spec.rb
@@
-4,7
+4,7
@@
require 'spec_helper'
describe 'apt::mark', type: :define do
let :title do
describe 'apt::mark', type: :define do
let :title do
- 'my
_
source'
+ 'mysource'
end
let :facts do
end
let :facts do
@@
-32,7
+32,7
@@
describe 'apt::mark', type: :define do
end
it {
end
it {
- is_expected.to contain_exec('apt-mark manual my
_
source')
+ is_expected.to contain_exec('apt-mark manual mysource')
}
end
}
end
@@
-51,8
+51,12
@@
describe 'apt::mark', type: :define do
[
'package',
'package1',
[
'package',
'package1',
- 'package
_
name',
+ 'package
.
name',
'package-name',
'package-name',
+ 'package+name',
+ 'p.ackagename',
+ 'p+ackagename',
+ 'p+',
].each do |value|
describe 'with a valid resource title' do
let :title do
].each do |value|
describe 'with a valid resource title' do
let :title do
@@
-71,13
+75,19
@@
describe 'apt::mark', type: :define do
end
end
end
end
+ # packagenames starting with + are not valid as the title according to puppet
+ # good thing this is also an illegal name for debian packages
[
'|| ls -la ||',
'packakge with space',
'package<>|',
'|| touch /tmp/foo.txt ||',
[
'|| ls -la ||',
'packakge with space',
'package<>|',
'|| touch /tmp/foo.txt ||',
+ 'package_name',
+ 'PackageName',
+ '.p',
+ 'p',
].each do |value|
].each do |value|
- describe
'with an invalid resource title'
do
+ describe
"with an invalid resource title [#{value}]"
do
let :title do
value
end
let :title do
value
end