Code Review
/
puppet-modules
/
puppetlabs-apt.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge pull request #524 from mhaskel/better_defined_check
[puppet-modules/puppetlabs-apt.git]
/
spec
/
classes
/
apt_spec.rb
diff --git
a/spec/classes/apt_spec.rb
b/spec/classes/apt_spec.rb
index ee7cd33a24e04610aef6a894d87e2c841dfb4d27..1c8cac7a03c27fd5ee43a9b7e70a816420809d38 100644
(file)
--- a/
spec/classes/apt_spec.rb
+++ b/
spec/classes/apt_spec.rb
@@
-1,6
+1,6
@@
require 'spec_helper'
describe 'apt' do
require 'spec_helper'
describe 'apt' do
- let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy'} }
+ let(:facts) { { :lsbdistid => 'Debian', :osfamily => 'Debian', :lsbdistcodename => 'wheezy'
, :puppetversion => Puppet.version
} }
context 'defaults' do
it { is_expected.to contain_file('sources.list').that_notifies('Exec[apt_update]').only_with({
context 'defaults' do
it { is_expected.to contain_file('sources.list').that_notifies('Exec[apt_update]').only_with({
@@
-101,8
+101,8
@@
describe 'apt' do
}
end
}
end
- it { is_expected.to contain_file('sources.list').with
out
({
- :content =>
"# Repos managed by puppet.\n"
,
+ it { is_expected.to contain_file('sources.list').with({
+ :content =>
nil
,
})}
it { is_expected.to contain_file('sources.list.d').with({
})}
it { is_expected.to contain_file('sources.list.d').with({
@@
-132,6
+132,7
@@
describe 'apt' do
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'Debian',
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'Debian',
+ :puppetversion => Puppet.version,
}
end
let(:params) { { :sources => {
}
end
let(:params) { { :sources => {
@@
-173,6
+174,7
@@
describe 'apt' do
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'Debian',
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'Debian',
+ :puppetversion => Puppet.version,
}
end
let(:params) { { :keys => {
}
end
let(:params) { { :keys => {
@@
-198,6
+200,7
@@
describe 'apt' do
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'ubuntu',
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'ubuntu',
+ :puppetversion => Puppet.version,
}
end
let(:params) { { :ppas => {
}
end
let(:params) { { :ppas => {
@@
-214,6
+217,7
@@
describe 'apt' do
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'Debian',
{ :osfamily => 'Debian',
:lsbdistcodename => 'precise',
:lsbdistid => 'Debian',
+ :puppetversion => Puppet.version,
}
end
let(:params) { { :settings => {
}
end
let(:params) { { :settings => {
@@
-230,7
+234,7
@@
describe 'apt' do
let(:params) { { :purge => { 'sources.list' => 'banana' }, } }
it do
expect {
let(:params) { { :purge => { 'sources.list' => 'banana' }, } }
it do
expect {
- is_expected.to compile
+ subject.call
}.to raise_error(Puppet::Error)
end
end
}.to raise_error(Puppet::Error)
end
end
@@
-239,7
+243,7
@@
describe 'apt' do
let(:params) { { :purge => { 'sources.list.d' => 'banana' }, } }
it do
expect {
let(:params) { { :purge => { 'sources.list.d' => 'banana' }, } }
it do
expect {
- is_expected.to compile
+ subject.call
}.to raise_error(Puppet::Error)
end
end
}.to raise_error(Puppet::Error)
end
end
@@
-248,7
+252,7
@@
describe 'apt' do
let(:params) { { :purge => { 'preferences' => 'banana' }, } }
it do
expect {
let(:params) { { :purge => { 'preferences' => 'banana' }, } }
it do
expect {
- is_expected.to compile
+ subject.call
}.to raise_error(Puppet::Error)
end
end
}.to raise_error(Puppet::Error)
end
end
@@
-257,19
+261,19
@@
describe 'apt' do
let(:params) { { :purge => { 'preferences.d' => 'banana' }, } }
it do
expect {
let(:params) { { :purge => { 'preferences.d' => 'banana' }, } }
it do
expect {
- is_expected.to compile
+ subject.call
}.to raise_error(Puppet::Error)
end
end
context 'with unsupported osfamily' do
let :facts do
}.to raise_error(Puppet::Error)
end
end
context 'with unsupported osfamily' do
let :facts do
- { :osfamily => 'Darwin', }
+ { :osfamily => 'Darwin',
:puppetversion => Puppet.version,
}
end
it do
expect {
end
it do
expect {
- is_expected.to compile
+ subject.call
}.to raise_error(Puppet::Error, /This module only works on Debian or derivatives like Ubuntu/)
end
end
}.to raise_error(Puppet::Error, /This module only works on Debian or derivatives like Ubuntu/)
end
end