Code Review
/
puppet-modules
/
puppetlabs-apt.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Cleaned up unit tests.
[puppet-modules/puppetlabs-apt.git]
/
manifests
/
ppa.pp
diff --git
a/manifests/ppa.pp
b/manifests/ppa.pp
index a55e1e0e5c7a075b04ee4861370d40e107a42254..5f5c6ae57421993afa99705d3d63b6de081fd066 100644
(file)
--- a/
manifests/ppa.pp
+++ b/
manifests/ppa.pp
@@
-36,11
+36,13
@@
define apt::ppa(
if defined(Class[apt]) {
$proxy_host = $apt::proxy_host
$proxy_port = $apt::proxy_port
if defined(Class[apt]) {
$proxy_host = $apt::proxy_host
$proxy_port = $apt::proxy_port
- case
$proxy_host {
-
false, ''
: {
+ case $proxy_host {
+
false, '', undef
: {
$proxy_env = []
$proxy_env = []
- }
- default: {$proxy_env = ["http_proxy=http://${proxy_host}:${proxy_port}", "https_proxy=http://${proxy_host}:${proxy_port}"]}
+ }
+ default: {
+ $proxy_env = ["http_proxy=http://${proxy_host}:${proxy_port}", "https_proxy=http://${proxy_host}:${proxy_port}"]
+ }
}
} else {
$proxy_env = []
}
} else {
$proxy_env = []
@@
-67,9
+69,6
@@
define apt::ppa(
file { "${sources_list_d}/${sources_list_d_filename}":
ensure => 'absent',
file { "${sources_list_d}/${sources_list_d_filename}":
ensure => 'absent',
- mode => '0644',
- owner => 'root',
- group => 'root',
notify => Exec['apt_update'],
}
}
notify => Exec['apt_update'],
}
}